From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1RjfQ1-0007VF-0s for bitcoin-development@lists.sourceforge.net; Sat, 07 Jan 2012 23:11:21 +0000 X-ACL-Warn: Received: from nm2-vm4.bullet.mail.ne1.yahoo.com ([98.138.91.162]) by sog-mx-3.v43.ch3.sourceforge.com with smtp (Exim 4.76) id 1RjfQ0-0007qT-6B for bitcoin-development@lists.sourceforge.net; Sat, 07 Jan 2012 23:11:20 +0000 Received: from [98.138.90.48] by nm2.bullet.mail.ne1.yahoo.com with NNFMP; 07 Jan 2012 23:11:15 -0000 Received: from [98.138.89.234] by tm1.bullet.mail.ne1.yahoo.com with NNFMP; 07 Jan 2012 23:11:15 -0000 Received: from [127.0.0.1] by omp1049.mail.ne1.yahoo.com with NNFMP; 07 Jan 2012 23:11:15 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 9174.94627.bm@omp1049.mail.ne1.yahoo.com Received: (qmail 79357 invoked by uid 60001); 7 Jan 2012 23:11:14 -0000 X-YMail-OSG: MMSRNU8VM1lWO1jzzdxYRk4oP8rSB19ppvb5GZtIRVHxDk9 TXrA.fXslhj.LgRkMAVUEei96Pz8RpIDYtNHUsPk__9hgeC8bw89maKSiFXn t.bl51sOt.lkGmthSZlMcIPqWL8AMiasVU0iVMIRpcw_Jwq9pZOXGOjHrTz0 jX4DmX5qq3EzD9kGdnYWAEMa9KyTM3b9wfWMSTU512EbfOd2g4PFshcAmekF rqIqjzkacCbtEyLDZkZxv11Q4L480d2iDZVX9AiLljeeweOWXFeDEisjgAgQ rDhnCKdnjDQtiq0JUd8ddRpcDiky8lTwVy5oEdlV.sRADFXopsDksqcRfvbY TmJCQfTwK91elaXSwINe87F6CGMFbwZ_yHWJ6gr.y4yYH8_lTS8F4JNIzKny rs1zFSpVkpPr8OKW6ms4kWWQpXHAJ4LTFiz_zqJw1t9QxoFNQNKbFYTI1RAo _.BdNp63DRazDypg7mn_k_H_yANCS97oSaXop99CbOVZKqXFznK1bBQ9nTjo 4_rsIQ_Kz0EIPPRES Received: from [92.20.155.29] by web121006.mail.ne1.yahoo.com via HTTP; Sat, 07 Jan 2012 15:11:14 PST X-Mailer: YahooMailWebService/0.8.115.331698 References: <1325956875.73286.YahooMailNeo@web121006.mail.ne1.yahoo.com> Message-ID: <1325977874.57604.YahooMailNeo@web121006.mail.ne1.yahoo.com> Date: Sat, 7 Jan 2012 15:11:14 -0800 (PST) From: Amir Taaki To: "bitcoin-development@lists.sourceforge.net" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.1 (/) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [98.138.91.162 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (zgenjix[at]yahoo.com) -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1RjfQ0-0007qT-6B Subject: Re: [Bitcoin-development] Pull 748 pay to script hash X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list Reply-To: Amir Taaki List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jan 2012 23:11:21 -0000 OK, here is one thing:=0A=0Awhat is the purpose behind counting the number = of sig ops after you have executed the script in ConnectInputs?=0ASeems lik= e it would be too late then.=0A=0A=0A=0A----- Original Message -----=0AFrom= : Gavin Andresen =0ATo: Amir Taaki =0ACc: Bitcoin Dev =0ASent: = Saturday, January 7, 2012 10:48 PM=0ASubject: Re: [Bitcoin-development] Pul= l 748 pay to script hash=0A=0A> It might be better for code review if the o= ld pull is reverted and then this one re-requested. That will make it easie= r=0A> to see the real changes.=0A=0AI count the 1 major merge then 8 commit= s to fix bugs or tweak=0Athings...=A0 I just tried reverting them and stopp= ed when I got scared=0AI'll accidentally revert a fix we do want to keep.= =0A=0AInstead, I updated my gavinandresen/master github branch to the state= =0Aof the tree just before the OP_EVAL merge, so for code review purposes= =0Ayou can look at:=0A=0Ahttps://github.com/gavinandresen/bitcoin-git/compa= re/master...pay_to_script_hash=0A=0AThere are unrelated 0.6 pulls in those = changes, too, but it should be=0Apretty obvious what is what.=0A=0A-- =0A--= =0AGavin Andresen=0A