From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1VRZOd-0006mJ-Pq for bitcoin-development@lists.sourceforge.net; Thu, 03 Oct 2013 03:16:11 +0000 X-ACL-Warn: Received: from nm28-vm4.bullet.mail.gq1.yahoo.com ([98.136.216.163]) by sog-mx-4.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1VRZOc-0003cs-AU for bitcoin-development@lists.sourceforge.net; Thu, 03 Oct 2013 03:16:11 +0000 Received: from [98.137.12.191] by nm28.bullet.mail.gq1.yahoo.com with NNFMP; 03 Oct 2013 03:16:04 -0000 Received: from [98.137.12.216] by tm12.bullet.mail.gq1.yahoo.com with NNFMP; 03 Oct 2013 03:16:04 -0000 Received: from [127.0.0.1] by omp1024.mail.gq1.yahoo.com with NNFMP; 03 Oct 2013 03:16:04 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 197909.88657.bm@omp1024.mail.gq1.yahoo.com Received: (qmail 7797 invoked by uid 60001); 3 Oct 2013 03:16:03 -0000 X-YMail-OSG: 1FUFgFwVM1mIsfIutbS07cEkcMiWb1sPZmt96T4OShWmxXw oAmOMuiLXy90IfdYnpxbrAI_ZSl5bVc.l0Oo5WYBhEWu25zP0zSfRZdu9s5t ZgElfD2R5y1W6A6QG1FI9W.trUaR4JiPUBmPQ7bEMvZasFscvaVRarZzPPkY FsxO4PoMDT_vMLG.qJIr0gcze14v_cHgEJhnp0jL4aF8xhPIhbpWw6s4mD6w j5_kClmojtWoDSbvojn_gWpCStizwspSNL0AMD4W07mMOYQwiraELr90wlbT X253_PS9vnISz_Ki61HTG_6RIbntIelrR4dTtAVy5i7HIB1j.Dj9cM_gQlzM 0UgF18ADBO_pTQWOTh8v9Yg5ZeJ4R2W5ijSlKDSbNhOG0rKl5fTqx0A8tJ9m HyxxVTrUbrHhtFXFBt0nc9sPD603JCBTiNRZgx5qCvIPI2eZN6NitQMwiZE7 XGMN4471NNWXe_crO_Slura2p5UXbFTvU5VmhbvrsUakg8jtJwvINCO4O959 vOIU.CG5tnkbvfytlkKQE6_hKCyheTkcna0xB2AOj8quL9pOODPRjSizLdpU hYHuRuFGK7HKJT6ivtwYnaNaaiAxPKwdBtHjuQEcL0xeU46TuVwqtu_sKfZo _YWRusIiFb3kdVMT6GWNA Received: from [68.196.240.212] by web124502.mail.ne1.yahoo.com via HTTP; Wed, 02 Oct 2013 20:16:03 PDT X-Rocket-MIMEInfo: 002.001, SSBvbmx5IGJyaW5nIHRoaXMgdXAgaGVyZSBzaW5jZSBJIGNhbid0IHJhaXNlIGh0dHBzOi8vYml0Y29pbnRhbGsub3JnPyBQZXJoYXBzIGl0IHJ1bnMgb24gdGhlIHNpbGsgcm9hZCBzZXJ2ZXJzOikKClVwb24gbG9va2luZyBhdCB0aGUgMC44LjUgJiBlYXJsaWVyIGNvZGUgZm9yIENEQjpSZXdyaXRlKCksIGluIHRoZSBmaWxlcyBkYi5oIGFuZCBkYi5jcHAsIHlvdSB3aWxsIG5vdGljZSB0aGF0IGluIGRiLmggaXQgaXMgZGVjbGFyZWQgYm9vbCBzdGF0aWMsIGJ1dCBpbiBkYi5jcHAgaXQgaXNuJ3QuIElzIHQBMAEBAQE- X-Mailer: YahooMailWebService/0.8.160.587 Message-ID: <1380770163.7534.YahooMailNeo@web124502.mail.ne1.yahoo.com> Date: Wed, 2 Oct 2013 20:16:03 -0700 (PDT) From: Ron To: "bitcoin-development@lists.sourceforge.net" MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="-626213187-280908893-1380770163=:7534" X-Spam-Score: 2.1 (++) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [98.136.216.163 listed in list.dnswl.org] 0.6 HK_RANDOM_ENVFROM Envelope sender username looks random 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rdwnj[at]yahoo.com) 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] -0.7 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: bitcointalk.org] 1.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1VRZOc-0003cs-AU Subject: [Bitcoin-development] on CDB::Rewrite() X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list Reply-To: Ron List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Oct 2013 03:16:12 -0000 ---626213187-280908893-1380770163=:7534 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable I only bring this up here since I can't raise https://bitcointalk.org? Perh= aps it runs on the silk road servers:)=0A=0AUpon looking at the 0.8.5 & ear= lier code for CDB:Rewrite(), in the files db.h and db.cpp, you will notice = that in db.h it is declared bool static, but in db.cpp it isn't. Is this a = problem? Or a feature? Or nothing at all?=0A=0A=0AFurthermore, it is called= only in wallet.cpp -->CWallet::EncryptWallet() but its return value is ign= ored? Again, intentional or a bug or a feature or a ...?=0ANow CWallet::Enc= ryptWallet() is called by AskPassphraseDialog::accept() and WalletModel::se= tWalletEncrypted()and they seem very interested in what=A0 CWallet::Encrypt= Wallet() returns. Could this be involved in some old issue with wallet encr= yption on bitcoin-qt 0.8.1?=0A=0AThere seems to be plenty of this kind of "= suspicious" code to ferret about in, with one's IDE during quiet moments. A= musing is to follow return 0 and return 1 to try and infer their meaning, t= heir intent?=0A=0A=0ARon=0A ---626213187-280908893-1380770163=:7534 Content-Type: text/html; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable
I only bring thi= s up here since I can't raise https://bitcointalk.org? Perhaps it runs on t= he silk road servers:)

Upon looking at the 0.8.5 &= amp; earlier code for CDB:Rewrite(), in the files db.h and db.cpp, you will= notice that in db.h it is declared bool static, but in db.cpp it isn't. Is= this a problem? Or a feature? Or nothing at all?

<= div style=3D"color: rgb(0, 0, 0); font-size: 16px; font-family: times new r= oman,new york,times,serif; background-color: transparent; font-style: norma= l;">Furthermore, it is called only in wallet.cpp -->CWallet::EncryptWall= et() but its return value is ignored? Again, intentional or a bug or a feature or a ...?
Now CWallet::EncryptWallet() is called by AskP= assphraseDialog::accept() and WalletModel::setWalletEncrypted()and they see= m very interested in what  CWallet::EncryptWallet() returns. Could thi= s be involved in some old issue with wallet encryption on bitcoin-qt 0.8.1?=

There seems to be plenty of this kind of "suspici= ous" code to ferret about in, with one's IDE during quiet moments. Amusing = is to follow return 0 and return 1 to try and infer their meaning, their intent?

Ron
---626213187-280908893-1380770163=:7534--