From: Tom Zander <tomz@freedommail.ch>
To: Greg Sanders <gsanders87@gmail.com>
Cc: Bitcoin Protocol Discussion <bitcoin-dev@lists.linuxfoundation.org>
Subject: Re: [bitcoin-dev] BIP draft: Extended block header hardfork
Date: Tue, 04 Apr 2017 18:17:02 +0200 [thread overview]
Message-ID: <1528041.Pzi3X2XRt7@strawberry> (raw)
In-Reply-To: <CAB3F3DtuYjxp6Cg-nprq7qZanF_F2y0xUM7RUzoJ7Fdn9HtJXw@mail.gmail.com>
I notice you didn’t read the actual full line :)
If you click on it, you’ll notice at the end of the line it says;
“chainparams.GetConsensus().BIP34Hash”
so, this is about BIP34.
On Tuesday, 4 April 2017 17:44:40 CEST Greg Sanders wrote:
> That's BIP30, he linked BIP34:
> https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L3004
>
> On Tue, Apr 4, 2017 at 11:32 AM, Tom Zander via bitcoin-dev <
>
> bitcoin-dev@lists.linuxfoundation.org> wrote:
> > Can you tell me where it is enforced?
> >
> > The only place I found was here;
> > https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L1793
> >
> > which doesn’t enforce it, all that code does is check that the txid is
> > unknown or fully spent.
> > And since the below idea from Russel would change the txid, it would
> > seem
> > no
> > full client would reject this.
> >
> > Maybe its in a BIP, but I can’t find it in the code.
> >
> > On Tuesday, 4 April 2017 16:59:12 CEST James Hilliard wrote:
> > > It is a consensus rule
> > > https://github.com/bitcoin/bips/blob/master/bip-0034.mediawiki
> > >
> > > On Tue, Apr 4, 2017 at 6:47 AM, Tom Zander via bitcoin-dev
> > >
> > > <bitcoin-dev@lists.linuxfoundation.org> wrote:
> > > > On Sunday, 2 April 2017 22:39:13 CEST Russell O'Connor via
> > > > bitcoin-dev
> > > >
> > > > wrote:
> > > >> Someone told me a while back that it would be more natural if we
> > > >> move
> > > >> the
> > > >>
> > > >> nHeight from the coinbase script to the coinbase locktime. Have
> > > >> you
> > > >> considered doing this?
> > > >
> > > > That change would not be a consensus change and thus free to make
> > > > any
> > > > day.
--
Tom Zander
Blog: https://zander.github.io
Vlog: https://vimeo.com/channels/tomscryptochannel
prev parent reply other threads:[~2017-04-04 16:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-02 20:13 [bitcoin-dev] BIP draft: Extended block header hardfork Johnson Lau
2017-04-02 20:39 ` Russell O'Connor
2017-04-03 3:36 ` Johnson Lau
2017-04-04 11:47 ` Tom Zander
2017-04-04 14:59 ` James Hilliard
2017-04-04 15:32 ` Tom Zander
2017-04-04 15:44 ` Greg Sanders
2017-04-04 16:03 ` Jean-Paul Kogelman
2017-04-04 16:17 ` Tom Zander [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528041.Pzi3X2XRt7@strawberry \
--to=tomz@freedommail.ch \
--cc=bitcoin-dev@lists.linuxfoundation.org \
--cc=gsanders87@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox