From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1Qf7JJ-00083C-1R for bitcoin-development@lists.sourceforge.net; Fri, 08 Jul 2011 09:25:21 +0000 X-ACL-Warn: Received: from rhcavuit02.kulnet.kuleuven.be ([134.58.240.130] helo=cavuit02.kulnet.kuleuven.be) by sog-mx-4.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1Qf7JH-0002fM-Od for bitcoin-development@lists.sourceforge.net; Fri, 08 Jul 2011 09:25:21 +0000 X-KULeuven-Envelope-From: sipa@ulyssis.org X-Spam-Status: not spam, SpamAssassin (not cached, score=-48.788, required 5, autolearn=disabled, DKIM_ADSP_CUSTOM_MED 0.00, FREEMAIL_FROM 0.00, KUL_SMTPS -50.00, NML_ADSP_CUSTOM_MED 1.20, T_TO_NO_BRKTS_FREEMAIL 0.01) X-KULeuven-Scanned: Found to be clean X-KULeuven-ID: 2021F128089.A4D96 X-KULeuven-Information: Katholieke Universiteit Leuven Received: from smtps01.kuleuven.be (smtpshost01.kulnet.kuleuven.be [134.58.240.74]) by cavuit02.kulnet.kuleuven.be (Postfix) with ESMTP id 2021F128089 for ; Fri, 8 Jul 2011 11:25:08 +0200 (CEST) Received: from smtp.ulyssis.org (mail.ulyssis.student.kuleuven.be [193.190.253.235]) by smtps01.kuleuven.be (Postfix) with ESMTP id 0169431E703 for ; Fri, 8 Jul 2011 11:25:08 +0200 (CEST) Received: from wop.ulyssis.org (wop.intern.ulyssis.org [192.168.0.182]) by smtp.ulyssis.org (Postfix) with ESMTP id EF35FF8001 for ; Fri, 8 Jul 2011 11:26:27 +0200 (CEST) Received: by wop.ulyssis.org (Postfix, from userid 615) id F09C587C1B0; Fri, 8 Jul 2011 11:25:07 +0200 (CEST) Date: Fri, 8 Jul 2011 11:25:07 +0200 X-Kuleuven: This mail passed the K.U.Leuven mailcluster From: Pieter Wuille To: bitcoin-development@lists.sourceforge.net Message-ID: <20110708092506.GA6641@ulyssis.org> References: <20110707111557.GA5231@ulyssis.org> <4E16A567.6020309@justmoon.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-PGP-Key: http://sipa.ulyssis.org/pubkey.asc User-Agent: Mutt/1.5.20 (2009-06-14) X-Spam-Score: 1.2 (+) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (pieter.wuille[at]gmail.com) 0.0 DKIM_ADSP_CUSTOM_MED No valid author signature, adsp_override is CUSTOM_MED 1.2 NML_ADSP_CUSTOM_MED ADSP custom_med hit, and not from a mailing list 0.0 T_TO_NO_BRKTS_FREEMAIL To: misformatted and free email service -0.0 AWL AWL: From: address is in the auto white-list X-Headers-End: 1Qf7JH-0002fM-Od Subject: Re: [Bitcoin-development] Version bytes X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jul 2011 09:25:21 -0000 On Fri, Jul 08, 2011 at 08:18:19AM +0000, John Smith wrote: > > On Fri, Jul 8, 2011 at 6:36 AM, Stefan Thomas wrote: > > > >> Hey Pieter, > >> > >> > Otherwise, we could reset testnet (not actually reset, just > >> > change its addresses a bit), and simply state odd=testnet, even=realnet. > >> > >> We could use the XOR hack for now and remove it the next time we reset > >> testnet. But I do think the 111 is baggage we want to get rid of. Using > >> the lsb as a simple flag is much cleaner. > > I agree it is cleaner, but I think breaking compatiblity with older address > (even testnet) is not a good idea right now. It is important to build an > image of stability and backward compatibility. > > So I vote for the XOR 111 hack :) It does have another advantage: it makes testnet codes visually (after base58 encoding) different from realnet ones, which is probably the reason why the relatively large number 111 was chosen. The only small change that can cause the first base58 character to remain equal, is a modification to nVersion of less than 5 in absolute value. PS: +/- 111 is also possible, instead of XOR 111. -- Pieter