From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1Qg5pP-0000Vd-CK for bitcoin-development@lists.sourceforge.net; Mon, 11 Jul 2011 02:02:31 +0000 X-ACL-Warn: Received: from zinan.dashjr.org ([173.242.112.54]) by sog-mx-2.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1Qg5pK-0002hy-G3 for bitcoin-development@lists.sourceforge.net; Mon, 11 Jul 2011 02:02:31 +0000 Received: from ishibashi.localnet (fl-67-77-87-241.dhcp.embarqhsd.net [67.77.87.241]) (Authenticated sender: luke-jr) by zinan.dashjr.org (Postfix) with ESMTPSA id 3137C560550; Mon, 11 Jul 2011 02:02:16 +0000 (UTC) From: "Luke-Jr" To: bitcoin-development@lists.sourceforge.net Date: Sun, 10 Jul 2011 22:01:51 -0400 User-Agent: KMail/1.13.7 (Linux/2.6.39-gentoo; KDE/4.6.4; x86_64; ; ) References: <97305540.4426247.1310337435268.JavaMail.fmail@mwmweb052> In-Reply-To: <97305540.4426247.1310337435268.JavaMail.fmail@mwmweb052> X-PGP-Key-Fingerprint: CE5A D56A 36CC 69FA E7D2 3558 665F C11D D53E 9583 X-PGP-Key-ID: 665FC11DD53E9583 X-PGP-Keyserver: x-hkp://subkeys.pgp.net MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201107102201.53937.luke@dashjr.org> X-Spam-Score: 0.1 (/) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay domain 0.1 AWL AWL: From: address is in the auto white-list X-Headers-End: 1Qg5pK-0002hy-G3 Cc: Michael Offel Subject: Re: [Bitcoin-development] overall bitcoin client code quality X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2011 02:02:31 -0000 On Sunday, July 10, 2011 6:37:15 PM Michael Offel wrote: > why Berkeley db 4 is used at all. Because it's a good tool for the job? Or you mean the version? Debian stable: 4.8 Gentoo stable: 4.8 Ubuntu LTS : 4.8 > Boost is also an heavy non standard dependency that is an unnecessary > barrier for new developers. Boost is pretty much standard C++ nowadays. > I'm talking about one file per class, no methods and single code line > longer than a screen page. It should be natural to write code like this > and I dislike having a lot of rules but the code shows that there is a > need for such thing. Blame your text editor if it can't show long lines sanely. The only problem I see with the style itself is the use of spaces instead of tabs. > My overall suggestion is to begin a complete rewrite, inspired by the old > code rather than moving a lot of "known to be somehow functional" around. There are many rewrites in progress, often with much better designs. > The official Bitcoin client should be some kind of an reference project > for other clients and must therefore be extra clean and well documented. Bitcoin is supposed to be an authorityless project. There is no official. > *everything else* Fix it yourself and submit the changes. If they don't get merged, fork.