From: "Luke-Jr" <luke@dashjr.org>
To: bitcoin-development@lists.sourceforge.net
Subject: Re: [Bitcoin-development] [PATCH] Change recommended fee to 0.001 BTC
Date: Mon, 11 Mar 2013 21:29:29 +0000 [thread overview]
Message-ID: <201303112129.30601.luke@dashjr.org> (raw)
In-Reply-To: <CAH2=CKy_o0wCWAfEHF0Zg4T1WGSoZ0o6LNB+uPXWdZmLv6siSg@mail.gmail.com>
On Monday, March 11, 2013 9:17:25 PM Rune Kjær Svendsen wrote:
> On Mon, Mar 11, 2013 at 9:46 PM, Luke-Jr <luke@dashjr.org> wrote:
> > On Monday, March 11, 2013 8:34:52 PM Rune Kjær Svendsen wrote:
> > > Ok. I'll fork on Github. Looking at the source, and some Qt
> >
> > documentation,
> >
> > > it should be doable to do string substitution for both the value and
> > > the unit.
> >
> > Side note: I imagine you'd be substituting a formatted string, and using
> > some
> > other function to format the string (which already exists to decide how
> > to display units elsewhere).
>
> I'm not entirely sure what you mean by this. I plan on using the method
> described on this page http://doc.qt.digia.com/3.1/i18n.html under "Use
> QString::arg() for Simple Arguments" and then just putting a %1 and %2 in
> the translation strings and substituting for value and unit, respectively.
> Haven't tested it yet, but that's what I plan to do.
eg, use a single %1 with
BitcoinUnits::format(walletModel->getOptionsModel()->getDisplayUnit(), amount)
> Where do you want the constant defined? In main.h alongside MIN_TX_FEE
> and MIN_RELAY_TX_FEE?
Sounds reasonable.
prev parent reply other threads:[~2013-03-11 21:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 19:27 [Bitcoin-development] [PATCH] Change recommended fee to 0.001 BTC Rune K. Svendsen
2013-03-11 19:35 ` Luke-Jr
2013-03-11 20:34 ` Rune Kjær Svendsen
2013-03-11 20:45 ` Gregory Maxwell
[not found] ` <201303112046.51263.luke@dashjr.org>
2013-03-11 21:17 ` Rune Kjær Svendsen
2013-03-11 21:29 ` Luke-Jr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303112129.30601.luke@dashjr.org \
--to=luke@dashjr.org \
--cc=bitcoin-development@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox