From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191]
	helo=mx.sourceforge.net)
	by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76)
	(envelope-from <luke@dashjr.org>) id 1UFAI0-0006ha-5M
	for bitcoin-development@lists.sourceforge.net;
	Mon, 11 Mar 2013 21:29:48 +0000
X-ACL-Warn: 
Received: from zinan.dashjr.org ([173.242.112.54])
	by sog-mx-1.v43.ch3.sourceforge.com with esmtp (Exim 4.76)
	id 1UFAHw-0004Pe-Ew for bitcoin-development@lists.sourceforge.net;
	Mon, 11 Mar 2013 21:29:48 +0000
Received: from ishibashi.localnet (unknown [173.170.142.26])
	(Authenticated sender: luke-jr)
	by zinan.dashjr.org (Postfix) with ESMTPSA id DC20A27A2966
	for <bitcoin-development@lists.sourceforge.net>;
	Mon, 11 Mar 2013 21:29:38 +0000 (UTC)
From: "Luke-Jr" <luke@dashjr.org>
To: bitcoin-development@lists.sourceforge.net
Date: Mon, 11 Mar 2013 21:29:29 +0000
User-Agent: KMail/1.13.7 (Linux/3.7.3-gentoo; KDE/4.9.5; x86_64; ; )
References: <1363030071-26731-1-git-send-email-runesvend@gmail.com>
	<201303112046.51263.luke@dashjr.org>
	<CAH2=CKy_o0wCWAfEHF0Zg4T1WGSoZ0o6LNB+uPXWdZmLv6siSg@mail.gmail.com>
In-Reply-To: <CAH2=CKy_o0wCWAfEHF0Zg4T1WGSoZ0o6LNB+uPXWdZmLv6siSg@mail.gmail.com>
X-PGP-Key-Fingerprint: E463 A93F 5F31 17EE DE6C 7316 BD02 9424 21F4 889F
X-PGP-Key-ID: BD02942421F4889F
X-PGP-Keyserver: hkp://pgp.mit.edu
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Message-Id: <201303112129.30601.luke@dashjr.org>
X-Spam-Score: -2.4 (--)
X-Spam-Report: Spam Filtering performed by mx.sourceforge.net.
	See http://spamassassin.org/tag/ for more details.
	-2.4 RP_MATCHES_RCVD Envelope sender domain matches handover relay
	domain
X-Headers-End: 1UFAHw-0004Pe-Ew
Subject: Re: [Bitcoin-development] [PATCH] Change recommended fee to 0.001
	BTC
X-BeenThere: bitcoin-development@lists.sourceforge.net
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: <bitcoin-development.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development>
List-Post: <mailto:bitcoin-development@lists.sourceforge.net>
List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>,
	<mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe>
X-List-Received-Date: Mon, 11 Mar 2013 21:29:48 -0000

On Monday, March 11, 2013 9:17:25 PM Rune Kj=E6r Svendsen wrote:
> On Mon, Mar 11, 2013 at 9:46 PM, Luke-Jr <luke@dashjr.org> wrote:
> > On Monday, March 11, 2013 8:34:52 PM Rune Kj=E6r Svendsen wrote:
> > > Ok. I'll fork on Github. Looking at the source, and some Qt
> >=20
> > documentation,
> >=20
> > > it should be doable to do string substitution for both the value and
> > > the unit.
> >=20
> > Side note: I imagine you'd be substituting a formatted string, and using
> > some
> > other function to format the string (which already exists to decide how
> > to display units elsewhere).
>=20
> I'm not entirely sure what you mean by this. I plan on using the method
> described on this page http://doc.qt.digia.com/3.1/i18n.html under "Use
> QString::arg() for Simple Arguments" and then just putting a %1 and %2 in
> the translation strings and substituting for value and unit, respectively.
> Haven't tested it yet, but that's what I plan to do.

eg, use a single %1 with
BitcoinUnits::format(walletModel->getOptionsModel()->getDisplayUnit(), amou=
nt)

> Where do you want the constant defined? In main.h alongside MIN_TX_FEE
> and MIN_RELAY_TX_FEE?

Sounds reasonable.