From: Peter Todd <pete@petertodd.org>
To: Mike Hearn <hearn@vinumeris.com>
Cc: Bitcoin Dev <bitcoin-dev@lists.linuxfoundation.org>
Subject: Re: [bitcoin-dev] Bitcoin XT Fork
Date: Thu, 20 Aug 2015 02:13:34 -0700 [thread overview]
Message-ID: <20150820091334.GA5448@muck> (raw)
In-Reply-To: <CA+w+GKTXAvq76sX4ttiYHhRcGp1MOynGAovYs8Dq1A1Q=9K4KQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2134 bytes --]
On Thu, Aug 20, 2015 at 11:00:14AM +0200, Mike Hearn via bitcoin-dev wrote:
> >
> > It is just that no one else is reckless enough to bypass the review process
>
>
> I keep seeing this notion crop up.
>
> I want to kill this idea right now:
>
> - There were months of public discussion leading to up the authoring of
> BIP 101, both on this mailing list and elsewhere.
>
> - BIP 101 was submitted for review via the normal process. Jeff Garzik
> specifically called Gavin out on Twitter and thanked him for following the
> process:
>
> https://twitter.com/jgarzik/status/614412097359708160
>
> https://github.com/bitcoin/bips/pull/163
>
> As you can see, other than a few minor typo fixes and a comment by sipa,
> there was no other review offered.
>
> - The implementation for BIP 101 was submitted to Bitcoin Core as a pull
> request, to invoke the code review process:
>
> https://github.com/bitcoin/bitcoin/pull/6341
>
> Some minor code layout suggestions were made by Cory and incorporated.
> Peter popped up to say there was no chance it'd ever be accepted ..... and
> no further review was done.
No, I said there was no chance it'd be accepted "due to a number of
BIP-level issues in addition to debate about the patch itself. For
instance, Gavin has never given any details about testing; at minimum
we'd need a BIP16 style quality assurance document. We also frown on
writing software with building expiration dates, let alone expiration
dates that trigger non-deterministically. (Note how my recently merged
CLTV considered the year 2038 problem to avoid needing a hard fork at
that date)"
Of course no further review was done - issues were identified and they
didn't get fixed. Why would we do further review on something that was
broken whose author wasn't interested in fixing even non-controversial
and obvious problems?
The process is to do review, fix issues identified, and repeat until all
issues are fixed.
--
'peter'[:-1]@petertodd.org
00000000000000000402fe6fb9ad613c93e12bddfc6ec02a2bd92f002050594d
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 650 bytes --]
next prev parent reply other threads:[~2015-08-20 9:13 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 16:53 [bitcoin-dev] Bitcoin XT Fork Adam Back
2015-08-19 17:22 ` Simon Liu
2015-08-19 18:13 ` Peter Todd
2015-08-19 23:37 ` Simon Liu
2015-08-19 17:28 ` Jorge Timón
2015-08-19 17:32 ` Btc Drak
2015-08-19 18:20 ` Peter Todd
2015-08-19 19:15 ` Btc Drak
2015-08-19 19:32 ` odinn
2015-08-19 19:48 ` Eric Lombrozo
2015-08-19 19:58 ` Jorge Timón
2015-08-19 20:04 ` Eric Lombrozo
2015-08-19 22:00 ` Jorge Timón
2015-08-19 23:07 ` Eric Voskuil
2015-08-19 23:27 ` Jorge Timón
2015-08-19 23:56 ` Jorge Timón
2015-08-20 1:00 ` GC
2015-08-20 1:17 ` Jorge Timón
2015-08-20 0:08 ` Eric Voskuil
2015-08-19 18:22 ` Jorge Timón
2015-08-19 19:12 ` Santino Napolitano
2015-08-19 19:28 ` Eric Lombrozo
2015-08-20 9:00 ` Mike Hearn
2015-08-20 9:13 ` Peter Todd [this message]
2015-08-21 3:01 ` odinn
-- strict thread matches above, loose matches on Subject: below --
2015-08-19 8:25 Btc Drak
2015-08-17 20:24 Theo Chino
2015-08-18 4:56 ` Dave Scotese
2015-08-15 17:43 Satoshi Nakamoto
2015-08-15 19:08 ` Laszlo Hanyecz
2015-08-15 19:10 ` jl2012
2015-08-17 11:40 ` Oliver Egginger
2015-08-17 11:44 ` Jorge Timón
2015-08-17 11:51 ` Oliver Egginger
2015-08-17 16:32 ` Jorge Timón
2015-08-17 17:01 ` Oliver Egginger
2015-08-17 17:15 ` Jorge Timón
2015-08-17 17:30 ` Btc Drak
2015-08-17 17:18 ` Gregory Maxwell
2015-08-17 19:14 ` Peter Todd
2015-08-17 17:28 ` Jeff Garzik
2015-08-17 19:03 ` Warren Togami Jr.
2015-08-17 20:37 ` Oliver Egginger
2015-08-18 5:16 ` Gregory Maxwell
2015-08-18 9:15 ` Warren Togami Jr.
2015-08-18 11:52 ` Micha Bailey
2015-08-18 18:57 ` Oliver Egginger
2015-08-18 20:59 ` Anon Moto
2015-08-19 1:03 ` Sergio Demian Lerner
2015-08-17 19:02 ` Anon Moto
2015-08-17 19:40 ` Marcel Jamin
2015-08-17 19:16 ` Hector Chu
2015-08-17 19:28 ` Gregory Maxwell
2015-08-17 19:39 ` Jorge Timón
2015-08-19 2:54 ` odinn
2015-08-19 2:59 ` Angel Leon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150820091334.GA5448@muck \
--to=pete@petertodd.org \
--cc=bitcoin-dev@lists.linuxfoundation.org \
--cc=hearn@vinumeris.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox