From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id B1073E2C for ; Fri, 13 Apr 2018 22:53:19 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from zinan.dashjr.org (zinan.dashjr.org [192.3.11.21]) by smtp1.linuxfoundation.org (Postfix) with ESMTP id 57A6F165 for ; Fri, 13 Apr 2018 22:53:19 +0000 (UTC) Received: from ishibashi.localnet (unknown [IPv6:2001:470:5:265:a45d:823b:2d27:961c]) (Authenticated sender: luke-jr) by zinan.dashjr.org (Postfix) with ESMTPSA id DE4DE38B759A; Fri, 13 Apr 2018 22:52:32 +0000 (UTC) X-Hashcash: 1:25:180413:bitcoin-dev@lists.linuxfoundation.org::hdDThYqcwA5Nwl2D:/MW4 X-Hashcash: 1:25:180413:andreas@schildbach.de::4HIC2DLZu/z+3gqJ:cp4mt From: Luke Dashjr To: bitcoin-dev@lists.linuxfoundation.org, Andreas Schildbach Date: Fri, 13 Apr 2018 22:52:23 +0000 User-Agent: KMail/1.13.7 (Linux/4.15.9-gentoo; KDE/4.14.37; x86_64; ; ) References: In-Reply-To: X-PGP-Key-Fingerprint: E463 A93F 5F31 17EE DE6C 7316 BD02 9424 21F4 889F X-PGP-Key-ID: BD02942421F4889F X-PGP-Keyserver: hkp://pgp.mit.edu MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201804132252.24419.luke@dashjr.org> X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: Re: [bitcoin-dev] BloomFilter issue with segwit addresses X-BeenThere: bitcoin-dev@lists.linuxfoundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Bitcoin Protocol Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 22:53:19 -0000 As I understand it, the plan is to deprecated and remove BIP37 entirely once BIP158 is implemented and deployed. In the meantime, Bitcoin Knots supports the MSG_FILTERED_WITNESS_BLOCK extension to download witness data. (Note that light clients currently have no way to verify the witness data is correct.) As far as matching goes, why not look for the specific COutPoints? That should work already with standard BIP37. Luke On Friday 13 April 2018 3:32:15 PM Andreas Schildbach via bitcoin-dev wrote: > Anton, a developer on the bitcoinj maiing list, recently made me aware > [1] of a compatibility issue between segwit and BIP37 (Bloom Filtering). > > The issue affects only P2WPKH and the special case of transactions > without change outputs (such as when emptying a wallet). In this case, > neither inputs not outputs contain any data elements that would cause a > match for the filter. The public key, which would match, goes to the > witness but not to the input. > > My suggestion was to include an OP_RETURN output with a matching public > key in such transactions. Anton confirmed that this workaround is indeed > working. But of course it nullifies some of the segwit's size improvements. > > I wonder if Bitcoin Core would be willing to extend the BIP37 matching > rules such that data elements in the witness are also matched against? > > > [1] https://groups.google.com/d/msg/bitcoinj/SJpLgjowc1I/V7u2BavvAwAJ > > _______________________________________________ > bitcoin-dev mailing list > bitcoin-dev@lists.linuxfoundation.org > https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev