From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 6DFDEC6C for ; Fri, 18 Oct 2019 22:46:33 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from newmail.dtrt.org (li1228-87.members.linode.com [45.79.129.87]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id DDD1670D for ; Fri, 18 Oct 2019 22:46:32 +0000 (UTC) Received: from harding by newmail.dtrt.org with local (Exim 4.92) (envelope-from ) id 1iLb0x-0002QR-Pi; Fri, 18 Oct 2019 18:46:31 -0400 Date: Fri, 18 Oct 2019 12:45:35 -1000 From: "David A. Harding" To: Eric Voskuil , Bitcoin Protocol Discussion Message-ID: <20191018224535.wy6f55grpfk2sncq@ganymede> References: <5C03EE5A-B29E-44BC-903F-7094E504580D@voskuil.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5C03EE5A-B29E-44BC-903F-7094E504580D@voskuil.org> User-Agent: NeoMutt/20180716 X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,KHOP_HELO_FCRDNS autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: Re: [bitcoin-dev] Removal of reject network messages from Bitcoin Core (BIP61) X-BeenThere: bitcoin-dev@lists.linuxfoundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Bitcoin Protocol Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Oct 2019 22:46:33 -0000 On Thu, Oct 17, 2019 at 01:16:47PM -0700, Eric Voskuil via bitcoin-dev wrote: > As this is a P2P protocol change it should be exposed as a version > increment (and a BIP) [...] > > BIP61 is explicit: > > “All implementations of the P2P protocol version 70,002 and later > should support the reject message.“ I don't think a new BIP or a version number increment is necessary. 1. "Should support" isn't the same as "must support". See https://tools.ietf.org/html/rfc2119 ; by that reading, implementations with protocol versions above 70,002 are not required to support the reject message. 2. If you don't implement a BIP, as Bitcoin Core explicitly doesn't any more for BIP61[1], you're not bound by its conditions. -Dave [1] https://github.com/bitcoin/bitcoin/blob/master/doc/bips.md "BIP61 [...] Support was removed in v0.20.0"