From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3640FC0893 for ; Wed, 23 Dec 2020 21:32:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 306CD86FBD for ; Wed, 23 Dec 2020 21:32:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AVibZrZ2fJW7 for ; Wed, 23 Dec 2020 21:32:55 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail-41103.protonmail.ch (mail-41103.protonmail.ch [185.70.41.103]) by hemlock.osuosl.org (Postfix) with ESMTPS id B931C86FAA for ; Wed, 23 Dec 2020 21:32:54 +0000 (UTC) Received: from mail-03.mail-europe.com (mail-03.mail-europe.com [91.134.188.129]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by mail-41103.protonmail.ch (Postfix) with ESMTPS id 1E96C2003144 for ; Wed, 23 Dec 2020 21:32:53 +0000 (UTC) Authentication-Results: mail-41103.protonmail.ch; dkim=pass (2048-bit key) header.d=achow101.com header.i=@achow101.com header.b="WLjXriDw" Date: Wed, 23 Dec 2020 21:32:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=achow101.com; s=protonmail2; t=1608759163; bh=f2/yzN0zndQztNXJVYyWxKFild94GPvVMyUvm1mjTzg=; h=Date:To:From:Reply-To:Subject:In-Reply-To:References:From; b=WLjXriDwNZQJgz0PS0/9e7dzS0r6pq6Cia/p0jb4P8zHnD5gD9c1BMEFXLf4kqU1C ShoErahCJCLtkFHAgXhdwrV4Ymm/73YWmDHjHW8e3p1mTSJFP6iRKh35Jnw5IsvU3V /A5xfOm+2EY0l3Hii0iewIMfP2waIDgE5d5Cf9mIT9h8DYK13Q1stLC/t9XiRobr9F EAfgnXPoGcrY34jVK966SgFXH83eefoOpOLt0vUcZjoFx0I3zAGXaUeXKuKiNvpc6+ VDIqNRmBQsqhqpjyuJymgzHNWCx3s66utOWFhxI1cvPUCi6N8yRWsniDIPALSN3UcQ 9mF5WMVkqPetg== To: Bitcoin Protocol Discussion From: Andrew Chow Reply-To: Andrew Chow Message-ID: <40089cb5-8d68-1868-c87b-241f2bd747fb@achow101.com> In-Reply-To: <5a4697cb-b9cb-b925-e78f-d5b53f025704@achow101.com> References: <1dd8c285-e3f4-4f03-d608-103a5026146d@achow101.com> <5a4697cb-b9cb-b925-e78f-d5b53f025704@achow101.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [bitcoin-dev] New PSBT version proposal X-BeenThere: bitcoin-dev@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Bitcoin Protocol Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Dec 2020 21:32:56 -0000 Hi All, The full modified BIP can be read at=20 https://github.com/achow101/bips/blob/psbt2/bip-0174.mediawiki. I will open a PR to the BIPs repo soon after further discussion on this. Andrew On 12/22/20 3:12 PM, Andrew Chow wrote: > Hi All, > > I have some updates on this after speaking with some people off-list. > > Firstly, the version number will be set to 2. In most discussions, this > proposal was being referred to as PSBT version 2, so it'll be easier and > clearer to set the version number to 2. > > For lock times, instead of a single=C2=A0 PSBT_IN_REQUIRED_LOCKTIME field= , > there will be 2 of them, one for a time based lock time, and the other > for height based. These will be: > * PSBT_IN_REQUIRED_TIME_LOCKTIME =3D 0x10 > =C2=A0 * Key: empty > =C2=A0 * Value: 32 bit unsigned little endian integer greater than or e= qual > to 500000000 representing the minimum Unix timestamp that this input > requires to be set as the transaction's lock time. Must be omitted in > PSBTv0, and may be omitted in PSBTv2 > * PSBT_IN_REQUIRED_HEIGHT_LOCKTIME =3D 0x11 > =C2=A0 * Key: empty > =C2=A0 * Value: 32 bit unsigned little endian integer less than 5000000= 00 > representing the minimum block height that this input requires to be set > as the transaction's lock time. Must be omitted in PSBTv0, and may be > omitted in PSBTv2. > > Having two lock time fields is necessary due to the behavior where all > inputs must use the same type of lock time (height or time). Thus if an > input requires a particular type of lock time, it must set the requisite > field. Any new inputs being added must be able to accommodate all > existing inputs' lock time type. This means they either must not have a > lock time specified (i.e. no OP_CLTV involved), or have branches that > allow the acceptance of either type. If an input has a lock time type > that is incompatible with the rest of the transaction, it must not be add= ed. > > PSBT_GLOBAL_PREFERRED_LOCKTIME is changed to purely be the fallback > option if no input lock time fields are present. If there are input lock > times, all lock time calculations must ignore it. > > Any role which does lock time calculation will first check if there are > input lock time fields. If there are not, it must then check for a > PSBT_GLOBAL_PREFERRED_LOCKTIME. If this field exists, its value is the > transaction's lock time. If it does not, the lock time is 0. If there > are input lock time fields, it must choose the type which does not > invalidate any inputs. The lock time is then determined to be the > maximum value of all of the lock time fields for the chosen type. > > > Additionally, I would like to add a new global field: > * PSBT_GLOBAL_UNDER_CONSTRUCTION =3D 0x05 > =C2=A0 * Key: empty > =C2=A0 * Value: A single byte as a boolean. 0 for False, 1 for True. Al= l > other values ore prohibited. Must be omitted for PSBTv0, may be omitted > in PSBTv2. > > PSBT_GLOBAL_UNDER_CONSTRUCTION is used to signal whether inputs and > outputs can be added to the PSBT. This flag may be set to True when > inputs and outputs are being updated, signed, and finalized. However > care must be taken when there are existing signatures. If this field is > omitted or set to False, no further inputs and outputs may be added to > the PSBT. > > Several rules must be followed to ensure that adding additional inputs > and outputs will not invalidate existing signatures. First, an input or > output adder must check for any existing signatures in all of the other > inputs. If there are none, the input or output may be added in any > position. If there are one or more signatures, each signature's sighash > type must be examined. Inputs may only be added if all existing > signatures use SIGHASH_ANYONECANPAY. Outputs may only be added if all > existing signatures use SIGHASH_NONE. If an input has a signature using > SIGHASH_SINGLE, the same number of inputs and outputs must be added > before that input and it's corresponding output. For all other sighash > types (i.e. SIGHASH_ALL and any future sighash types), no inputs or > outputs may be added to the PSBT. Specific exceptions can be made in the > future for additional sighash types. > > Furthermore, these newly added inputs must follow additional lock time > rules. Because all signatures, regardless of sighash type, sign the > transaction lock time, newly added inputs when there are existing > signatures must have the same type of lock time used in the transaction, > and must be less than or equal to the transaction lock time. It must not > cause the transaction lock time to change, otherwise the signatures will > be invalidated. > > > Lastly, to uniquely identify transactions for combiners, a txid can be > computed from the information present in the PSBT. Internally, combiners > can create an unsigned transaction given the transaction version, the > input prevouts, the outputs, and the computed locktime. This can then be > used to calculate a txid and thus used as a way to identify PSBTs. > Combiners will need to do this for all version 2 PSBTs in order to avoid > combining distinct transactions. > > > Andrew Chow > > On 12/9/20 5:25 PM, Andrew Chow wrote: >> Hi All, >> >> I would like to propose a new PSBT version that addresses a few >> deficiencies in the current PSBT v0. As this will be backwards >> incompatible, a new PSBT version will be used, v1. >> >> The primary change is to truly have all input and output data for each >> in their respective maps. Instead of having to parse an unsigned >> transaction and lookup some data from there, and other data from the >> correct map, all of the data for an input will be contained in its map. >> Doing so also disallows PSBT_GLOBAL_UNSIGNED_TX in this new version. >> Thus I propose that the following fields be added: >> >> Global: >> * PSBT_GLOBAL_TX_VERSION =3D 0x02 >> =C2=A0 * Key: empty >> =C2=A0 * Value: 32-bit little endian unsigned integer for the transac= tion >> version number. Must be provided in PSBT v1 and omitted in v0. >> * PSBT_GLOBAL_PREFERRED_LOCKTIME =3D 0x03 >> =C2=A0 * Key: empty >> =C2=A0 * Value: 32 bit little endian unsigned integer for the preferr= ed >> transaction lock time. Must be omitted in PSBT v0. May be provided in >> PSBT v1, assumed to be 0 if not provided. >> * PSBT_GLOBAL_INPUT_COUNT =3D 0x04 >> =C2=A0 * Key: empty >> =C2=A0 * Value: Compact size unsigned integer. Number of inputs in th= is >> PSBT. Must be provided in PSBT v1 and omitted in v0. >> * PSBT_GLOBAL_OUTPUT_COUNT =3D 0x05 >> =C2=A0 * Key: empty >> =C2=A0 * Value: Compact size unsigned integer. Number of outputs in t= his >> PSBT. Must be provided in PSBT v1 and omitted in v0. >> >> Input: >> * PSBT_IN_PREVIOUS_TXID =3D 0x0e >> =C2=A0 * Key: empty >> =C2=A0 * Value: 32 byte txid of the previous transaction whose output= at >> PSBT_IN_OUTPUT_INDEX is being spent. Must be provided in PSBT v1 and >> omitted in v0. >> * PSBT_IN_OUTPUT_INDEX =3D 0x0f >> =C2=A0 * Key: empty >> =C2=A0 * Value: 32 bit little endian integer for the index of the out= put >> being spent. Must be provided in PSBT v1 and omitted in v0. >> * PSBT_IN_SEQUENCE =3D 0x0f >> =C2=A0 * Key: empty >> =C2=A0 * Value: 32 bit unsigned little endian integer for the sequenc= e >> number. Must be omitted in PSBT v0. May be provided in PSBT v1 assumed >> to be max sequence (0xffffffff) if not provided. >> * PSBT_IN_REQUIRED_LOCKTIME =3D 0x10 >> =C2=A0 * Key: empty >> =C2=A0 * Value: 32 bit unsigned little endian integer for the lock ti= me that >> this input requires. Must be omitted in PSBT v0. May be provided in PSBT >> v1, assumed to be 0 if not provided. >> >> Output: >> * PSBT_OUT_VALUE =3D 0x03 >> =C2=A0 * Key: empty >> =C2=A0 * Value: 64-bit unsigned little endian integer for the output'= s >> amount in satoshis. Must be provided in PSBT v1 and omitted in v0. >> * PSBT_OUT_OUTPUT_SCRIPT =3D 0x04 >> =C2=A0 * Key: empty >> =C2=A0 * Value: The script for this output. Otherwise known as the >> scriptPubKey. Must be provided in PSBT v1 and omitted in v0. >> >> This change allows for PSBT to be used in the construction of >> transactions. With these new fields, inputs and outputs can be added as >> needed. One caveat is that there is no longer a unique transaction >> identifier so more care must be taken when combining PSBTs. >> Additionally, adding new inputs and outputs must be done such that >> signatures are not invalidated. This may be harder to specify. >> >> An important thing to note in this proposal are the fields >> PSBT_GLOBAL_PREFERRED_LOCKTIME and PSBT_IN_REQUIRED_LOCKTIME. A Bitcoin >> transaction only has a single locktime yet a PSBT may have multiple >> locktimes. To choose the locktime for the transaction, finalizers must >> choose the maximum of all of the *_LOCKTIME fields. >> PSBT_IN_REQUIRED_LOCKTIME is added because some inputs, such as those >> involving OP_CHECKLOCKTIMEVERIFY, require a specific minimum locktime to >> be set. This field allows finalizers to choose a locktime that is high >> enough for all inputs without needing to understand the scripts >> involved. The PSBT_GLOBAL_PREFERRED_LOCKTIME is the locktime to use if >> no inputs require a particular locktime. >> >> As these changes disallow the PSBT_GLOBAL_UNSIGNED_TX field, PSBT v1 >> needs the version number bump to enforce backwards incompatibility. >> However once the inputs and outputs of a PSBT are decided, a PSBT could >> be "downgraded" back to v0 by creating the unsigned transaction from the >> above fields, and then dropping these new fields. >> >> If the list finds that these changes are reasonable, I will write a PR >> to modify BIP 174 to incorporate them. >> >> Thanks, >> Andrew Chow