From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1XyjSh-0004jh-JW for bitcoin-development@lists.sourceforge.net; Wed, 10 Dec 2014 15:45:59 +0000 Received-SPF: pass (sog-mx-1.v43.ch3.sourceforge.com: domain of gmail.com designates 209.85.220.46 as permitted sender) client-ip=209.85.220.46; envelope-from=austin.walne@gmail.com; helo=mail-pa0-f46.google.com; Received: from mail-pa0-f46.google.com ([209.85.220.46]) by sog-mx-1.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1XyjSg-0003Xg-MQ for bitcoin-development@lists.sourceforge.net; Wed, 10 Dec 2014 15:45:59 +0000 Received: by mail-pa0-f46.google.com with SMTP id lf10so2411943pab.19 for ; Wed, 10 Dec 2014 07:45:53 -0800 (PST) X-Received: by 10.66.163.196 with SMTP id yk4mr7959285pab.57.1418226352265; Wed, 10 Dec 2014 07:45:52 -0800 (PST) Received: from [10.10.1.3] (198.23.103.82-static.reverse.softlayer.com. [198.23.103.82]) by mx.google.com with ESMTPSA id on1sm4601785pdb.32.2014.12.10.07.45.50 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 10 Dec 2014 07:45:50 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) From: Austin Walne X-Mailer: iPhone Mail (12B436) In-Reply-To: Date: Wed, 10 Dec 2014 07:45:49 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <48E6B6DA-F977-409C-AEDD-53572986438D@gmail.com> References: <54876653.4020403@certimix.com> <548769FA.5040406@bluematt.me> To: Wladimir X-Spam-Score: -1.6 (-) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (austin.walne[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1XyjSg-0003Xg-MQ Cc: Bitcoin Dev Subject: Re: [Bitcoin-development] ACK NACK utACK "Concept ACK" X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Dec 2014 15:45:59 -0000 I've had these same questions myself. I'm happy to write up some documentati= on this afternoon. I can draft something based on this thread. What other ke= y terminology should be included? > On Dec 10, 2014, at 00:21, Wladimir wrote: >=20 >> On Wed, Dec 10, 2014 at 6:47 AM, Wladimir wrote: >> Abbreviations: >>=20 >> Concept ACK -> agree with the idea and overall direction, but haven't >> reviewed the code changes nor tested it >> utACK -> reviewed the code changes, but did not put it through any testin= g >> Tested ACK -> reviewed the code changes and verified the functionality/bu= g fix >=20 > And there is also NACK, that's an aspecific 'I wouldn't like this > merged'. I always explain why in the text. >=20 > A document on this would be welcome, as it may look like Martian to > outsiders. That's been brought up many times before, but no one ever > created it. >=20 > Wladimir >=20 > --------------------------------------------------------------------------= ---- > Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server > from Actuate! Instantly Supercharge Your Business Reports and Dashboards > with Interactivity, Sharing, Native Excel Exports, App Integration & more > Get technology previously reserved for billion-dollar corporations, FREE > http://pubads.g.doubleclick.net/gampad/clk?id=3D164703151&iu=3D/4140/ostg.= clktrk > _______________________________________________ > Bitcoin-development mailing list > Bitcoin-development@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/bitcoin-development