public inbox for bitcoindev@googlegroups.com
 help / color / mirror / Atom feed
From: Jonas Schnelli <dev@jonasschnelli.ch>
To: Andreas Schildbach <andreas@schildbach.de>,
	Bitcoin Protocol Discussion
	<bitcoin-dev@lists.linuxfoundation.org>
Subject: Re: [bitcoin-dev] BloomFilter issue with segwit addresses
Date: Fri, 13 Apr 2018 21:12:47 +0200	[thread overview]
Message-ID: <4A0CD31A-8745-4425-99FC-5DF12FA3B917@jonasschnelli.ch> (raw)
In-Reply-To: <paqids$e14$1@blaine.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 575 bytes --]

Hi Andreas

Thanks for bringing this up and this seems indeed to be suboptimal.

> I wonder if Bitcoin Core would be willing to extend the BIP37 matching
> rules such that data elements in the witness are also matched against?

Bitcoin Core is not an identity that can be „willing to extend“ (or reject) a feature.
Someone needs to come up with a proposal (pull request).

Maybe an extension for BIP37 would make sense (*meh*).
Just inserting the witness data into the bloom filter seems to be an easy solution (CBloomFilter::IsRelevantAndUpdate())

/jonas

[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2018-04-13 19:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-13 15:32 [bitcoin-dev] BloomFilter issue with segwit addresses Andreas Schildbach
2018-04-13 19:12 ` Jonas Schnelli [this message]
2018-04-13 22:15   ` Jim Posen
2018-04-14 16:14     ` Christian Decker
2018-04-14 19:46       ` Jim Posen
2018-04-15 18:37       ` Andreas Schildbach
2018-04-13 22:52 ` Luke Dashjr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A0CD31A-8745-4425-99FC-5DF12FA3B917@jonasschnelli.ch \
    --to=dev@jonasschnelli.ch \
    --cc=andreas@schildbach.de \
    --cc=bitcoin-dev@lists.linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox