public inbox for bitcoindev@googlegroups.com
 help / color / mirror / Atom feed
From: Alan Grimes <agrimes@speakeasy.net>
To: bitcoin-development@lists.sourceforge.net
Subject: Re: [Bitcoin-development] overall bitcoin client code quality
Date: Tue, 12 Jul 2011 00:13:04 -0400	[thread overview]
Message-ID: <4E1BC9D0.3080104@speakeasy.net> (raw)
In-Reply-To: <201107102201.53937.luke@dashjr.org>

Yeah, I'm starting to run into real design problems in my attempt to 
write a bitcoin daemon, namely I'm trying to figure out how to manage 
connections and peers and how to interpret and coordinate messages from 
peers.

While spying on the old code, I noticed one major problem that could be 
fixed quite easily. That is, the 1 class-per .h/.cpp rule is completely 
ignored in main.h/cpp and net.h/cpp If all of the classes in the project 
were re-factored to their own files, it would be much easier to audit 
what was interacting with what. I think this work could be done within 
16 programmer hours.

The old codebase doesn't build on my system but I'd be willing to rough 
it in anyway.

I think this should be done in parallel to efforts, such as mine, to 
re-implement major functionality.

-- 
E T F
N H E
D E D

Powers are not rights.




  reply	other threads:[~2011-07-12  4:14 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-10 22:37 [Bitcoin-development] overall bitcoin client code quality Michael Offel
2011-07-10 23:07 ` Douglas Huff
2011-07-10 23:31 ` Jeff Garzik
2011-07-10 23:36 ` Matt Corallo
2011-07-11  2:01 ` Luke-Jr
2011-07-12  4:13   ` Alan Grimes [this message]
2011-07-12  5:19     ` Jeff Garzik
2011-07-11  9:33 ` Mike Hearn
2011-07-12  3:31   ` Gavin Andresen
2011-07-12  7:21   ` John Smith
2011-07-12 22:50   ` Michael Offel
2011-07-12 21:47 Michael Offel
2011-07-12 23:40 ` Gregory Maxwell
2011-07-13  0:17 ` Matt Corallo
2011-07-13 11:50   ` Mike Hearn
2011-07-13 13:04     ` Andy Parkins
2011-07-13 18:37       ` Luke-Jr
2011-07-13 21:41         ` Andy Parkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E1BC9D0.3080104@speakeasy.net \
    --to=agrimes@speakeasy.net \
    --cc=bitcoin-development@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox