From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1QgUMF-00089V-G0 for bitcoin-development@lists.sourceforge.net; Tue, 12 Jul 2011 04:14:03 +0000 Received-SPF: pass (sog-mx-3.v43.ch3.sourceforge.com: domain of speakeasy.net designates 69.17.117.49 as permitted sender) client-ip=69.17.117.49; envelope-from=agrimes@speakeasy.net; helo=mail5.sea5.speakeasy.net; Received: from mail5.sea5.speakeasy.net ([69.17.117.49]) by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1QgUME-0003c3-Kk for bitcoin-development@lists.sourceforge.net; Tue, 12 Jul 2011 04:14:03 +0000 Received: (qmail 5674 invoked from network); 12 Jul 2011 04:13:56 -0000 Received: from dsl092-168-049.wdc2.dsl.speakeasy.net (HELO [10.0.0.4]) ([66.92.168.49]) (envelope-sender ) by mail5.sea5.speakeasy.net (qmail-ldap-1.03) with AES256-SHA encrypted SMTP for ; 12 Jul 2011 04:13:56 -0000 Message-ID: <4E1BC9D0.3080104@speakeasy.net> Date: Tue, 12 Jul 2011 00:13:04 -0400 From: Alan Grimes User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110711 Firefox/5.0 SeaMonkey/2.2 MIME-Version: 1.0 To: bitcoin-development@lists.sourceforge.net References: <97305540.4426247.1310337435268.JavaMail.fmail@mwmweb052> <201107102201.53937.luke@dashjr.org> In-Reply-To: <201107102201.53937.luke@dashjr.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.5 (-) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -0.0 SPF_PASS SPF: sender matches SPF record X-Headers-End: 1QgUME-0003c3-Kk Subject: Re: [Bitcoin-development] overall bitcoin client code quality X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2011 04:14:03 -0000 Yeah, I'm starting to run into real design problems in my attempt to write a bitcoin daemon, namely I'm trying to figure out how to manage connections and peers and how to interpret and coordinate messages from peers. While spying on the old code, I noticed one major problem that could be fixed quite easily. That is, the 1 class-per .h/.cpp rule is completely ignored in main.h/cpp and net.h/cpp If all of the classes in the project were re-factored to their own files, it would be much easier to audit what was interacting with what. I think this work could be done within 16 programmer hours. The old codebase doesn't build on my system but I'd be willing to rough it in anyway. I think this should be done in parallel to efforts, such as mine, to re-implement major functionality. -- E T F N H E D E D Powers are not rights.