From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1Vacx6-00050m-LR for bitcoin-development@lists.sourceforge.net; Mon, 28 Oct 2013 02:53:12 +0000 X-ACL-Warn: Received: from serv.jerviss.org ([12.47.47.47] helo=inana.jerviss.org) by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1Vacx5-00039Q-Jo for bitcoin-development@lists.sourceforge.net; Mon, 28 Oct 2013 02:53:12 +0000 Received: from [10.8.2.254] ([192.151.168.109]) (username: kjj authenticated by PLAIN symmetric_key_bits=0) by inana.jerviss.org (8.13.6/8.12.11) with ESMTP id r9S2qv2o028874 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 27 Oct 2013 21:53:03 -0500 Message-ID: <526DD18A.7060201@jerviss.org> Date: Sun, 27 Oct 2013 21:52:58 -0500 From: kjj User-Agent: Mozilla/5.0 (Windows NT 5.2; WOW64; rv:24.0) Gecko/20100101 SeaMonkey/2.21 MIME-Version: 1.0 To: Gavin Andresen References: <274a1888-276c-4aa6-a818-68f548fbe0fa@me.com> <9DCDB8F6-E3B2-426B-A41E-087E66B3821A@gmail.com> <526B45DB.2030200@jerviss.org> In-Reply-To: Content-Type: multipart/alternative; boundary="------------050804060402000507010002" Received-SPF: pass (inana.jerviss.org: 192.151.168.109 is authenticated by a trusted mechanism) X-Spam-Score: -1.0 (-) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: doubleclick.net] -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain -0.5 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain 1.0 HTML_MESSAGE BODY: HTML included in message X-Headers-End: 1Vacx5-00039Q-Jo Cc: Bitcoin Dev Subject: Re: [Bitcoin-development] Feedback requested: "reject" p2p message X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Oct 2013 02:53:12 -0000 This is a multi-part message in MIME format. --------------050804060402000507010002 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Any reason not to use actual HTTP codes? I'm not aware of any major deficiency in them. Most of them won't apply to us, which is fine, they don't seem to apply to HTTP either. We can extend the scheme on our own if we find a good reason to. That implies 16 bits, or a varint. I would avoid a string or varstring here; we already have a text field. Varint vs. 16 bits is a minor issue, and arguments can be made in both directions. I flipped a coin and got heads, so I'll say varint. Gavin Andresen wrote: > RE: use HTTP-like status codes: > > Okey dokey, I'll add a one-byte machine-readable HTTP-like status > code. Unless y'all want a 32-bit status code. Or maybe a varint. Or a > three-character numeric string. I really and truly don't care, but I > am writing this code right now so whatever you want, decide quickly. > > If anybody has strong feelings about what the reject categories should > be, then please take the time to write a specific list, I can't read > your mind.... > > > -- > -- > Gavin Andresen > > > ------------------------------------------------------------------------------ > October Webinars: Code for Performance > Free Intel webinars can help you accelerate application performance. > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from > the latest Intel processors and coprocessors. See abstracts and register > > http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk > > > _______________________________________________ > Bitcoin-development mailing list > Bitcoin-development@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/bitcoin-development --------------050804060402000507010002 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit
Any reason not to use actual HTTP codes?  I'm not aware of any major deficiency in them.  Most of them won't apply to us, which is fine, they don't seem to apply to HTTP either.  We can extend the scheme on our own if we find a good reason to.

That implies 16 bits, or a varint.  I would avoid a string or varstring here; we already have a text field.  Varint vs. 16 bits is a minor issue, and arguments can be made in both directions.  I flipped a coin and got heads, so I'll say varint.

Gavin Andresen wrote:
RE: use HTTP-like status codes:

Okey dokey, I'll add a one-byte machine-readable HTTP-like status code. Unless y'all want a 32-bit status code.  Or maybe a varint. Or a three-character numeric string. I really and truly don't care, but I am writing this code right now so whatever you want, decide quickly.

If anybody has strong feelings about what the reject categories should be, then please take the time to write a specific list, I can't read your mind....


--
--
Gavin Andresen


------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk


_______________________________________________
Bitcoin-development mailing list
Bitcoin-development@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bitcoin-development

--------------050804060402000507010002--