From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1VbS8t-0000YJ-V0 for bitcoin-development@lists.sourceforge.net; Wed, 30 Oct 2013 09:32:47 +0000 Received: from mail-pb0-f45.google.com ([209.85.160.45]) by sog-mx-2.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1VbS8s-0002RB-HV for bitcoin-development@lists.sourceforge.net; Wed, 30 Oct 2013 09:32:47 +0000 Received: by mail-pb0-f45.google.com with SMTP id ma3so1123494pbc.32 for ; Wed, 30 Oct 2013 02:32:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:organization:user-agent :mime-version:to:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=ZOic2q4RzOUHYiIKvOV8Uu6OCGtJmhM88Qhj1gA9JP0=; b=llQ2yhhCXGZJsgpEI5TJrbnhspM0uMDNpwNidLEeQnlldTQ6XzU12pggb1Bn+J1E3s UY/ERoQx9Llj/pYnbZhJfLlsiewsr/cyVo82/bWNBcdx3znhGrwRSAkRpYQCp5/08gS2 kKS5hAgV40I+JevVhR3w4zqCz7ayMTTmMXt/N4RirhEwJl5tOdJcPpvI59WlBoeYyFtS nk1VV9Xqpg6TIAD/AUZ44DEtGBtmMZkF0fo2cqC+/nZYXvs2+sA3/72e3tsuIKrGU+Uz sK1YCNtN/i+EApQnbsoTHEepl4Xxp3FwRmc0YPwk97VXTawmhu+W0PPmiucxkkuCAyDL Jr4Q== X-Gm-Message-State: ALoCoQls+dE4j6Zfr2RHKI8DgCi9aDRIuM4a7ozF5GBhQWc8UAeo5ERw+Ikn9pG7UjyLl9vNbC1g X-Received: by 10.66.178.143 with SMTP id cy15mr1988738pac.105.1383123910391; Wed, 30 Oct 2013 02:05:10 -0700 (PDT) Received: from phobos.local (50-0-36-80.dsl.dynamic.sonic.net. [50.0.36.80]) by mx.google.com with ESMTPSA id xe9sm3340744pab.0.2013.10.30.02.05.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 30 Oct 2013 02:05:09 -0700 (PDT) Message-ID: <5270CBC1.7080506@monetize.io> Date: Wed, 30 Oct 2013 02:05:05 -0700 From: Mark Friedenbach Organization: Monetize.io Inc. User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: bitcoin-development@lists.sourceforge.net References: <274a1888-276c-4aa6-a818-68f548fbe0fa@me.com> <9DCDB8F6-E3B2-426B-A41E-087E66B3821A@gmail.com> <526B45DB.2030200@jerviss.org> <526DD18A.7060201@jerviss.org> <20131029101452.GA15808@savin> <7a22afbd-ad30-4748-8c88-9a1eda3e2fe9@email.android.com> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: enigmail.net] X-Headers-End: 1VbS8s-0002RB-HV Subject: Re: [Bitcoin-development] Feedback requested: "reject" p2p message X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Oct 2013 09:32:48 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 If I understand the code correctly, it's not about rejecting blocks. It's about noticing that >50% of recent blocks are declaring a version number that is meaningless to you. Chances are, there's been a soft fork and you should upgrade. On 10/30/13 1:24 AM, Mike Hearn wrote: > > But if you are getting soft-forked recent versions of the > reference implementation WILL alert you; see this code in > main.cpp: > > > Perhaps I'm confused about how we're using the term soft fork. My > understanding is that this is where a new upgrade is designed to > look valid to old nodes, and if you don't upgrade you rely on the > miner majority to get you "back on track". For instance, P2SH was > done this way - old nodes that didn't upgrade during that > transition believed all spends of P2SH outputs were valid, even > those spending someone elses coins. > > In this case, the code you cite won't do anything because your > client will never reject a block during a soft-forking upgrade, > even if it does something that's supposed to be invalid or > nonsensical. > > If a new block version changes the serialization format or script > language or SIGHASH rules such that old clients reject the block, > then they will end up on a hard fork and the alerting code will > trigger, which is correct and as it should be. -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.19 (Darwin) Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJScMvBAAoJEAdzVfsmodw4I5sQAL0Wq4e7b6/KX2zl9RmtFl5S qM9ZJkJV8qzirj1hMgVwvnuOj147Vb3EkJujxeMa8ujepXKZ215mMCLnCHPzWPpJ jTtOBn1FCkCUbyt9uSbZ+56NR+ElmSOsDpAJ8IR9VywHriCxm4OIAMCLTR6CKRfr 6NWySvjEMlsSHyr7DFaJTlMqo+KIUWGmP7tdPu1L2AvNE+613dI5q76IjUHYoxhu 2dDtanYUvFCsdLZEnjTr1N45BBf1mTSlPfmA1ZWHgM779h6VIyb0TeO+iCaxpvWp 2RpSDj3+diFdMUK2uu69ZcwkREH0/RoQLOys6U5DfaGkpPtjY0YXB5DwN9quKgzX padWzbQ0flpwWLYOPYrWATz4sWflxZJu6wHAcUkRS5k9crOLVjritXs1205x7YET 0H9jtbqXmBRXidCP2BOZPdq0PGDF8g2VeEHR69JRe3F3dBfSvbgHfKoiF1jpLLqb rttoP+nD4ZRX8FesV2E/DEZgDZJMd8eqDKNDjq7Db4BTDg24Nq2ATNE2fBtenXwI nXVNdmnvjDxjF0weJGlYgaQTfgVwHRxs+j4qgY4VLM0qEYplhHgg+KmOMFUtxAF/ sZv6w56XtCZS3LdNONAJSZzXIcqgmcodiWKVxkTL29dsWKikcBL5cG9ipdfmjQKT eccFOHArsbW3eSfKP/Mb =FSQI -----END PGP SIGNATURE-----