From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1YhQru-0004GF-IG for bitcoin-development@lists.sourceforge.net; Sun, 12 Apr 2015 23:00:46 +0000 X-ACL-Warn: Received: from mail-pd0-f170.google.com ([209.85.192.170]) by sog-mx-4.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1YhQrs-0002h7-AQ for bitcoin-development@lists.sourceforge.net; Sun, 12 Apr 2015 23:00:46 +0000 Received: by pdbnk13 with SMTP id nk13so86735259pdb.0 for ; Sun, 12 Apr 2015 16:00:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type; bh=q7yoiTkuo+XPVW3YyoOrcQrBXHyY4OyvLtSWcLZWeU4=; b=B/STz7yxjZ9tJ9rVXE5xO4+8mlQcRrNbyTvAhCreSGwQqz9IIp3ML48XbzZIUabUnJ Bo01VQ402vJUwG767oiox23ToqMnd+FZCa/Itq5twT8BzhYUcW3Sk9BG/ycMzuVjsog8 G0Zrbr7huQB2SwXILp5sN05it/49Dn/yBUp8DXBygaTnbVU0kIMCiV3MxUWUTZI7lRYQ iU85cOK7qs2b68i9Io+17BqVmeliu8Gs2wlTjx4fuqoeiVc3lt9CzvgGpuHkDqhBiBBO vg84N3aDWkNGNtPp5ZCQyfWK4GoYKVHeRxCeIj2z5gB6LOyHjQ9BUxXyfqm/+RookjY0 /ZTA== X-Gm-Message-State: ALoCoQkXpd0Cq58ZudFofXf8G4bXo6tozz8ihDoB58h5yt4TPJwSnCSeRXoIAx+6OlHGZqbbFvVg X-Received: by 10.68.135.199 with SMTP id pu7mr21011251pbb.153.1428878176223; Sun, 12 Apr 2015 15:36:16 -0700 (PDT) Received: from seanmb.att.net ([2602:306:ce08:9dc0:f5ca:572e:ee19:e397]) by mx.google.com with ESMTPSA id qh9sm5216259pbc.24.2015.04.12.15.36.13 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 12 Apr 2015 15:36:14 -0700 (PDT) Message-ID: <552AF35C.7060407@msgilligan.com> Date: Sun, 12 Apr 2015 15:36:12 -0700 From: Sean Gilligan User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Pieter Wuille , Bitcoin Dev References: In-Reply-To: Content-Type: multipart/alternative; boundary="------------040503030007050105080107" X-Spam-Score: 1.0 (+) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 1.0 HTML_MESSAGE BODY: HTML included in message X-Headers-End: 1YhQrs-0002h7-AQ Subject: Re: [Bitcoin-development] Deprecating Bitcoin Core's regtest-specific `setgenerate` behaviour X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Apr 2015 23:00:46 -0000 This is a multi-part message in MIME format. --------------040503030007050105080107 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit I would recommend adding the new method and deprecating (as in warning against using) the old one for one major release. Then removing it altogether in the following major release. I have written a Java RPC client and Groovy/Spock functional tests that use the current call. A separate `generate` or `generateblocks` call is a great idea. However, I try to keep my tests compatible with the current stable and unstable versions of Bitcoin Core (and the Omni Core fork) and would have to write code that checks the RPC server version (or checks for the presence of the new call, falling back to the old one) to support the use cases that I need to support. Not a huge deal, but I'm probably not the only one. -- Sean On 4/12/15 7:26 AM, Pieter Wuille wrote: > Hello everyone, > > Bitcoin Core's `setgenerate` RPC call has had a special meaning for > -regtest (namely instantaneously mining a number of blocks, instead of > starting a background CPU miner). > > We're planning to deprecate that overloaded behaviour, and replace it > with a separate RPC call `generate`. Is there any software or user who > would need compatibility with the old behaviour? We're generally very > conservative in changing RPC behaviour, but as this is not related to > any production functionality, we may as well just switch it. > > Note that the bitcoin.org developer documentation > will need to be updated. > > -- > Pieter > > > > ------------------------------------------------------------------------------ > BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT > Develop your own process in accordance with the BPMN 2 standard > Learn Process modeling best practices with Bonita BPM through live exercises > http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ > source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF > > > _______________________________________________ > Bitcoin-development mailing list > Bitcoin-development@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/bitcoin-development --------------040503030007050105080107 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
I would recommend adding the new method and deprecating (as in warning against using) the old one for one major release. Then removing it altogether in the following major release.

I have written a Java RPC client and Groovy/Spock functional tests <https://github.com/msgilligan/bitcoin-spock> that use the current call. A separate `generate` or `generateblocks` call is a great idea.

However, I try to keep my tests compatible with the current stable and unstable versions of Bitcoin Core (and the Omni Core fork) and would have to write code that checks the RPC server version (or checks for the presence of the new call, falling back to the old one) to support the use cases that I need to support. Not a huge deal, but I'm probably not the only one.

-- Sean


On 4/12/15 7:26 AM, Pieter Wuille wrote:
Hello everyone,

Bitcoin Core's `setgenerate` RPC call has had a special meaning for -regtest (namely instantaneously mining a number of blocks, instead of starting a background CPU miner).

We're planning to deprecate that overloaded behaviour, and replace it with a separate RPC call `generate`. Is there any software or user who would need compatibility with the old behaviour? We're generally very conservative in changing RPC behaviour, but as this is not related to any production functionality, we may as well just switch it.

Note that the bitcoin.org developer documentation will need to be updated.

--
Pieter



------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF


_______________________________________________
Bitcoin-development mailing list
Bitcoin-development@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bitcoin-development

--------------040503030007050105080107--