From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id CA0A4149C for ; Wed, 7 Oct 2015 17:33:05 +0000 (UTC) X-Greylist: delayed 00:07:43 by SQLgrey-1.7.6 Received: from mail.domob.eu (mail.domob.eu [92.222.9.28]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 0489EF0 for ; Wed, 7 Oct 2015 17:33:03 +0000 (UTC) Received: from [0.0.0.0] (vps149390.ovh.net [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.domob.eu (Postfix) with ESMTPSA id ED0F73B6 for ; Wed, 7 Oct 2015 19:25:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=domob.eu; s=default; t=1444238719; bh=lDgPimCPIKB+dRN2BI0btGWHFqXt1TgcVLeMefeaW9g=; h=Date:From:To:Subject:From; b=BZW1lHbZ8J/UnMrUPasGMtWrno6eekgyqn7u+b9JR3szmbMQsnv4g5gCsn/RJIMMQ d56zcJlHf/KNsddGYqZzVdEkIoYc2hC5f3tmrQfBCT/pF2OVc0IZmTFSOEmEPWEsQg MlVzMMCG4SCYwB0aDaQuV2K5C4d7gGt5F+PXrUOVwKOj7ANY7s/9FpCNNWSDKWyB2K Mkq/zStdrOfxiFuyKnVoDx8TIQJxxUcMDtIo43pH/iER7Dta9JfC+EIznWks0oLJZ1 rVTo6DSauNw5ML//kNhyeafrkraEovcY3BuZ+3ecFo3ObwImcWE8/L4wABY0ExIcXZ p/hY2bXQNXNX0aDn1pAwz6kvSz6l7F6oNSYnR19leHvsAdclEdWfbSZ1Llb5Cbxfu4 /4pS/mzzXUvZUVhe3Yw3nBeGe7ZUo85bM8Ek8wEUdNTR4fjBImwomGp66yKoVhqCcP +b4gBLowY5qYOf9xIrksBqZ2Czlc/lFD59vZKFYSDEyKhOgH/+wZYU9IfxDgCpfhhh dgtP1NvKtJu3355Qdc+l0JJWnEzJI6ZLuHlxuF+fml39rEm2uiDuA4nwdJ4p432Iqj aqNPGndNInVQBzpgoTY5uOQjdQmx5mletTOwEUUlSSkYKW9hpNpknDfD2F1cpZKKrl RotbM7yBstiFNhY3oRnztVoM= Message-ID: <56155572.5040501@domob.eu> Date: Wed, 07 Oct 2015 19:25:06 +0200 From: Daniel Kraft User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: bitcoin-dev@lists.linuxfoundation.org OpenPGP: id=A7330737 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="R0hWu1bs2sokwjFdNlLPMuuFSFjfjxOAv" X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, T_RP_MATCHES_RCVD autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [bitcoin-dev] The new obfuscation patch & GetStats X-BeenThere: bitcoin-dev@lists.linuxfoundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Bitcoin Development Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Oct 2015 17:33:05 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --R0hWu1bs2sokwjFdNlLPMuuFSFjfjxOAv Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi! I hope this is not a stupid question, but I thought I'd ask here first instead of opening a Github ticket (in case I'm wrong). With the recently merged "obfuscation" patch, content of the "chainstate" LevelDB is obfuscated by XOR'ing against a random "key". This is handled by CLevelDBWrapper's Read/Write methods, which probably cover most of the usecases. *However*, shouldn't it also be handled when iterating over the database? In particular, I would expect that the obfuscation key is applied before line 119 in txdb.cpp (i. e., while iterating over the coin database in CCoinsViewDB::GetStats). Is there a reason why this need not be done there, or is this an actual oversight? Yours, Daniel --=20 http://www.domob.eu/ OpenPGP: 1142 850E 6DFF 65BA 63D6 88A8 B249 2AC4 A733 0737 Namecoin: id/domob -> https://nameid.org/?name=3Ddomob -- Done: Arc-Bar-Cav-Hea-Kni-Ran-Rog-Sam-Tou-Val-Wiz To go: Mon-Pri --R0hWu1bs2sokwjFdNlLPMuuFSFjfjxOAv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJWFVV4AAoJEFcvuTrTyRk7TgkQAIHsS1Ec7ASuc+s59Kruc5V1 XDZLUf27wMvvcqeZNpCtMuUMaMy2jtvr7RfTHT29qbSPFmN1yaXcOsgLiACrC6Ul hHhD5RAa4xal7DavoEt85+HxGmMbQLC6yFiD4wW1orJHegwYT0dFjr6Ff8SquB7D OjQ84WENuDO7H8+B8a5fJOTmBpN5gKZ0Ci9MSZBc9AoFEL8orrgyhrXU/jC9NOo2 ZQZfkCOMAVpquZfxE8saK84t/dPzDzKcy+r6kPP+q091Y3odCIj7Y2z/uv8zUI0F +S2yZ9FKnoiX1smqn5c/ScyUqrRq2zniRIJ6AV8zwG59CNRY+VJ6HKLbLag90/CE ksFVNE5gc9C7sD1defrZdEDeQjqHtjInrI9IHyFnGAYE9ToM/3gkmBkfXhrlwZYy yPfGDtxUvRDp2tMbWmOdTUBrQo3pqRGP4gXqhQgW61oYaMnfKjGxylI2JdQDJhq1 tYmKAT5NmDtTDp62U1QcY/F41cr4foombpLVLp+hTSYJCBv7+aq6yrTiMdOeb9sM 41dtXfGKb20dHdub0Bp64wK7ICWrctHqqmCJBcXLY2SZpx7UPGWnmI7dWIrVms5h wWzJ73ALYyzwwYksfJVTumDJhWQ2p2Gy2T2Y4Te7Z0j4PuGRJPkSEYzRFkIFC1JV nlQeZwb0hJ6+u0heNxFE =6uHx -----END PGP SIGNATURE----- --R0hWu1bs2sokwjFdNlLPMuuFSFjfjxOAv--