From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id A00FEB43 for ; Fri, 27 Sep 2019 11:01:29 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from ozlabs.org (ozlabs.org [203.11.71.1]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id A8FEA1C0 for ; Fri, 27 Sep 2019 11:01:28 +0000 (UTC) Received: by ozlabs.org (Postfix, from userid 1011) id 46fpkt11yQz9sNx; Fri, 27 Sep 2019 21:01:26 +1000 (AEST) From: Rusty Russell To: Gleb Naumenko , Bitcoin Protocol Discussion In-Reply-To: <8914e269-e922-43f4-8846-9fb21a8044f3@Spark> References: <8914e269-e922-43f4-8846-9fb21a8044f3@Spark> Date: Fri, 27 Sep 2019 11:38:27 +0930 Message-ID: <87wodu7ap0.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00, DATE_IN_PAST_06_12, RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: Re: [bitcoin-dev] New BIP for p2p messages/state enabling reconciliation-based protocols (Erlay) X-BeenThere: bitcoin-dev@lists.linuxfoundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Bitcoin Protocol Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Sep 2019 11:01:29 -0000 Hi Gleb, Minor feedback on reading the draft: > sendrecon: > uint32 version Must be exactly 1 currently. At risk of quoting myself[1]: data doesn't have requirements. Actors do. In this case, I assume you mean "writers must set this to 1". What do readers do if it's not? > reqreconcil > uint8 q Coefficient used to estimate set difference. You describe how to calculate q (as a floating point value), but not how to encode it? > Every node stores sets of 128-bit truncated IDs per every peer "*a* set..." or is it "two sets" (if you include the snapshot?). And " *for* every peer" (maybe "which supports tx reconciliation?") > To the best of our knowledge, PinSketch is more bandwidth efficient > than IBLT, especially for the small differences in sets we expect to > operate over. Remove "To the best of our knowledge, ": that makes it sound like it's up for debate. I've implemented and experimented with IBLT, and it's worse. Cheers, Rusty. [1] https://github.com/lightningnetwork/lightning-rfc/blob/master/CONTRIBUTING.md#writing-the-requirements