From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id C16C5125C for ; Thu, 15 Mar 2018 09:17:26 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-ot0-f169.google.com (mail-ot0-f169.google.com [74.125.82.169]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 217EC356 for ; Thu, 15 Mar 2018 09:17:26 +0000 (UTC) Received: by mail-ot0-f169.google.com with SMTP id l12-v6so6156059otj.7 for ; Thu, 15 Mar 2018 02:17:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=voskuil-org.20150623.gappssmtp.com; s=20150623; h=from:content-transfer-encoding:mime-version:date:subject:message-id :references:in-reply-to:to; bh=ebW7e1/xudiUAJxUwp53jLtWCnp7KDR5pDlcH3GKEmE=; b=TQqWa9Eedvg+6bsEYOIjhvVyA4x5Qg+OVacQMhD92ePaecgwdioRVCRYrtqqBwXWK7 oIzDG1E/r15RYkLZ/PXFAE+bMG0QiGLtNK+2ttBI2SYAuxe37ul99IWce9SCFo8qWCxG Q9A7/RwbOGxI0/qIAnwKeZMgjav7JTLSXFldPOPGY8DZKzlksW5o9O01QMgjO9UQmONS rVSXm6LNdtPKACD0DI2G9NAFTpijvtXgUidBgAAjGvAqRMBcgQUCaGlEfErwtLqEoJib MGGk9GN+MmX8ZPQt7rO1H6VO42Wk2+gUO52iXQnG56rR5TVR8PP2L8l8LuTgVlDrAQQK IHtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version:date :subject:message-id:references:in-reply-to:to; bh=ebW7e1/xudiUAJxUwp53jLtWCnp7KDR5pDlcH3GKEmE=; b=Z0eAbD/WzJJS0PExs5yxLnwxnC0KQPtCk0/6Z7EF6iFJgu1hwKV0tgWaSGd1o62pu/ 3aQ7iAPMHyYNadD6m4688+Wi2ssHCaWNc1TYI8tIE+xd8V3m7c1jOa9AA49T+R8BufcL vnZIKAPjaLq2HFxPjbUMsHFniVWOJfMhztt+4lylixR4Uhd3fTcB4oj7D8JdgclpymZD jI1tUVHXL94ocYNebp3ol+IQkt1EGo++5kDlqTxbifPEm+If9iYQ7Ob1yRIuCZohE8Av RD/AKq4J+5HQWiLFOdCf3lV6NPoguMRbVjasTxTk8r0IBqxoUN/RGlMuHpoDWjELtRMz cNKw== X-Gm-Message-State: AElRT7HBI9rYi+A0Qq7MwUrdPaWtiDclqH8i2xjSbHD5WjKJZa1ikeRI WUOtcQm+fnxVwFRLT7gpDue9yoWuL50= X-Google-Smtp-Source: AG47ELtKz1AFEudJVLP1p5sIDAWCxKUjK7ePc/roZeRTuqBBHDXIpA/yjDofABMpOrw5V2aGX1rc9w== X-Received: by 10.157.64.11 with SMTP id m11mr5231189ote.185.1521105445371; Thu, 15 Mar 2018 02:17:25 -0700 (PDT) Received: from [10.221.57.40] (mobile-107-107-184-3.mycingular.net. [107.107.184.3]) by smtp.gmail.com with ESMTPSA id q8sm2507184oig.30.2018.03.15.02.17.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Mar 2018 02:17:24 -0700 (PDT) From: Eric Voskuil Content-Type: multipart/alternative; boundary=Apple-Mail-27BCA3BE-1D47-4606-BB6A-D3E06E545C5D Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (1.0) Date: Thu, 15 Mar 2018 10:17:22 +0100 Message-Id: <8C660724-A76D-44C1-9140-AD3215768CE1@voskuil.org> References: <620d4b5e-61c4-4501-9787-c73109908418@achow101.com> In-Reply-To: <620d4b5e-61c4-4501-9787-c73109908418@achow101.com> To: Andrew Chow , Bitcoin Protocol Discussion X-Mailer: iPhone Mail (15D100) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HTML_MESSAGE, MIME_QP_LONG_LINE, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org X-Mailman-Approved-At: Thu, 15 Mar 2018 12:53:35 +0000 Subject: Re: [bitcoin-dev] version.relay behavior change X-BeenThere: bitcoin-dev@lists.linuxfoundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Bitcoin Protocol Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 09:17:26 -0000 --Apple-Mail-27BCA3BE-1D47-4606-BB6A-D3E06E545C5D Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Thanks for the reply Andrew. I=E2=80=99ve reviewed the relevant Core sources= and I do not see any problem. We have also synced against a Core node local= ly and not seen the problem. The reason I suspected it was Core is that it is very common and all of the U= ser Agents are consistent (with an occasional exception for forked nodes). S= o there=E2=80=99s no easy way to determine what sort of nodes we are seeing.= =20 We tend to cycle through many more connections during sync than a Core node,= so may just be seeing it more frequently, but I assume Core would log this b= ehavior as well. Even so, seeing that wouldn=E2=80=99t help much. I=E2=80=99= m as certain as I can be at this point that we are setting the flag and vers= ion correctly (and that we do not set bip37 filters). This behavior started infrequently with 0.14.0 peers and has become more com= mon over time. Just wondering at this point what fork would report as Core a= nd be that common? We used to drop peers that did this (for protocol noncomp= liance), and I=E2=80=99m considering reinstating that behavior. e > On Mar 9, 2018, at 16:33, Andrew Chow via bitcoin-dev wrote: >=20 > Looking through the code, I don't think that this behavior has changed. Ar= e you sure that you are actually connected to Satoshi:0.15.0 nodes and not a= node that has simply set their user-agent to that (i.e. not a real Satoshi:= 0.15.0 node)? >=20 > If what you are seeing is true, it is likely a bug and not an intentional c= hange. In that case, can you provide specific details on how to reproduce? >=20 > Andrew >=20 >> On 03/09/2018 02:50 AM, Eric Voskuil via bitcoin-dev wrote: >> /Satoshi:0.15.0/ and later nodes appear to be no longer honoring the >> version.relay=3Dfalse flag (BIP37). Could someone familiar with the chang= e >> please explain the rational? >>=20 >> Thanks, >>=20 >> e >>=20 >>=20 >>=20 >> _______________________________________________ >> bitcoin-dev mailing list >> bitcoin-dev@lists.linuxfoundation.org >> https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev >=20 > _______________________________________________ > bitcoin-dev mailing list > bitcoin-dev@lists.linuxfoundation.org > https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev --Apple-Mail-27BCA3BE-1D47-4606-BB6A-D3E06E545C5D Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Thanks for the reply Andrew= . I=E2=80=99ve reviewed the relevant Core sources and I do not see any probl= em. We have also synced against a Core node locally and not seen the problem= .

The reason I suspected it was Core is that it is v= ery common and all of the User Agents are consistent (with an occasional exc= eption for forked nodes). So there=E2=80=99s no easy way to determine what s= ort of nodes we are seeing. 

We tend to cycle t= hrough many more connections during sync than a Core node, so may just be se= eing it more frequently, but I assume Core would log this behavior as well. E= ven so, seeing that wouldn=E2=80=99t help much. I=E2=80=99m as certain as I c= an be at this point that we are setting the flag and version correctly (and t= hat we do not set bip37 filters).

This behavior sta= rted infrequently with 0.14.0 peers and has become more common over time. Ju= st wondering at this point what fork would report as Core and be that common= ? We used to drop peers that did this (for protocol noncompliance), and I=E2= =80=99m considering reinstating that behavior.

e

On Mar 9, 2018, at 16:33, Andrew Chow via bitcoin-dev <bitcoin-dev@lists.linuxfo= undation.org> wrote:

=20 =20 =20

Looking through the code, I don't think that this behavior has changed. Are you sure that you are actually connected to Satoshi:0.15.0 nodes and not a node that has simply set their user-agent to that (i.e. not a real Satoshi:0.15.0 node)?

If what you are seeing is true, it is likely a bug and not an intentional change. In that case, can you provide specific details on how to reproduce?

Andrew


On 03/09/2018 02:50 AM, Eric Voskuil via bitcoin-dev wrote:
/Satoshi:0.15.0/ and later nodes appear to be no longer=
 honoring the
version.relay=3Dfalse flag (BIP37). Could someone familiar with the change
please explain the rational?

Thanks,

e




_______________________________________________
bitcoin-dev mailing list
bitcoin-dev@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/lis=
tinfo/bitcoin-dev

=20
____________________= ___________________________
bitcoin-dev mailing list<= br>bitcoin-de= v@lists.linuxfoundation.org
https://lists.linuxfoundation= .org/mailman/listinfo/bitcoin-dev
= --Apple-Mail-27BCA3BE-1D47-4606-BB6A-D3E06E545C5D--