public inbox for bitcoindev@googlegroups.com
 help / color / mirror / Atom feed
From: Gavin <gavinandresen@gmail.com>
To: Jouke Hofman <jouke@bitonic.nl>
Cc: "bitcoin-development@lists.sourceforge.net"
	<bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] Proposal to change payment protocol signing
Date: Tue, 29 Apr 2014 12:12:49 -0700	[thread overview]
Message-ID: <91F405F1-7F82-42EA-8517-7E2A9444D91A@gmail.com> (raw)
In-Reply-To: <535FD6DC.8000002@bitonic.nl>

Consensus is the spec should be clarified to match current behavior, so it won't change.

--
Gavin Andresen


> On Apr 29, 2014, at 9:44 AM, Jouke Hofman <jouke@bitonic.nl> wrote:
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> We have BIP70 already in use (over a hundred paid requests).
> 
> Could you elaborate on why this needs changing?
> 
> 
> 
>> On 28-04-14 14:39, Gavin Andresen wrote:
>> There is a discussion about clarifying how BIP70 signs payment
>> requests here: https://github.com/bitcoin/bips/pull/41
>> 
>> The issue is what to do with the signature field before signing.
>> The code Mike and I initially wrote does this:
>> 
>> request.set_signature(string(""));
>> 
>> (sets signature to the empty string)
>> 
>> I think that is a mistake; it should be:
>> 
>> request.clear_signature();
>> 
>> (clears signature field, so it is not serialized at all).
>> 
>> So: if you are implementing, or have implemented, the payment
>> protocol, please chime in. I'd like to change the spec and the
>> reference implementation NOW, while BIP70 is still a 'Draft'.
>> 
>> Because this type of "hey, I'm implementing your standard and it
>> doesn't work the way I think it should" mistake is exactly why BIPs
>> take a while before being declared 'Final.'
>> 
>> 
>> 
>> 
>> ---------------------------------------



      reply	other threads:[~2014-04-29 19:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-28 12:39 [Bitcoin-development] Proposal to change payment protocol signing Gavin Andresen
2014-04-28 16:14 ` Mike Hearn
2014-04-28 20:53   ` Ryan X. Charles
2014-04-29 16:44 ` Jouke Hofman
2014-04-29 19:12   ` Gavin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91F405F1-7F82-42EA-8517-7E2A9444D91A@gmail.com \
    --to=gavinandresen@gmail.com \
    --cc=bitcoin-development@lists.sourceforge.net \
    --cc=jouke@bitonic.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox