public inbox for bitcoindev@googlegroups.com
 help / color / mirror / Atom feed
From: Jonas Schnelli <dev@jonasschnelli.ch>
To: Pavol Rusnak <stick@satoshilabs.com>,
	Bitcoin Protocol Discussion
	<bitcoin-dev@lists.linuxfoundation.org>
Subject: Re: [bitcoin-dev] Proposal: Extended serialization format for BIP-32 wallets
Date: Thu, 7 Sep 2017 09:47:16 -0700	[thread overview]
Message-ID: <A806D2EB-744F-41A9-91C1-603F89E9005B@jonasschnelli.ch> (raw)
In-Reply-To: <0d405f5d-c0a4-bad7-b6c3-08ba4424bf17@satoshilabs.com>

[-- Attachment #1: Type: text/plain, Size: 1753 bytes --]

Thanks for the proposal.

Three points it could see as possible improvements:

1.
From what I know, the exact birthday in seconds doesn’t matter that much therefore it may be possible to just use 13 or 16bits to create a representation in week from 2009-01-09 00:00 UTC. 13bits would give you 157 years.
Always round down to the beginning of the week when the key was created.
But not sure if it’s worth to save ~two bytes for that.
Also not sure if the key-birthday in seconds could have a security or privacy implication (week maybe better).

2.
Would it make sense to have special depth bytes that directly implies it’s a BIP44 master key (and therefore avoid the bip32 path serialisation)? I know some „centralised“ table need to be available for that which may be not a good idea. But maybe the BIP could reserve a couple of depth-bytes (maybe 0xF0 to 0xFF) for predefined paths.

3.
Would adding a version bit make sense to allow future extensions?


/jonas


> Am 06.09.2017 um 15:29 schrieb Pavol Rusnak via bitcoin-dev <bitcoin-dev@lists.linuxfoundation.org>:
> 
> The discussion about changing bip32 version bytes for SegWit got me
> thinking and I ended up with what I think is the best proposal:
> 
> https://github.com/satoshilabs/slips/blob/master/slip-0032.md
> 
> (It is hosted in SL repo for now, but if there is will, I would love to
> have this added to BIP repo as an extension to BIP32)
> 
> Feel free to comment.
> 
> --
> Best Regards / S pozdravom,
> 
> Pavol "stick" Rusnak
> CTO, SatoshiLabs
> _______________________________________________
> bitcoin-dev mailing list
> bitcoin-dev@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev


[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2017-09-07 16:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-06 22:29 [bitcoin-dev] Proposal: Extended serialization format for BIP-32 wallets Pavol Rusnak
2017-09-07  3:52 ` Kabuto Samourai
2017-09-07 16:25   ` Pavol Rusnak
2017-09-07 16:30     ` Kabuto Samourai
2017-09-07 16:37       ` Pavol Rusnak
2017-09-07 18:02         ` Peter Todd
2017-09-07  4:29 ` Thomas Voegtlin
2017-09-07 16:23   ` Pavol Rusnak
2017-09-07 16:33     ` Kabuto Samourai
2017-09-07 19:35     ` Andreas Schildbach
2017-09-07 20:00       ` Pavol Rusnak
2017-09-07 20:39     ` Thomas Voegtlin
2017-09-07 16:47 ` Jonas Schnelli [this message]
2017-09-07 18:09   ` Peter Todd
2017-09-07 18:38   ` Pavol Rusnak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A806D2EB-744F-41A9-91C1-603F89E9005B@jonasschnelli.ch \
    --to=dev@jonasschnelli.ch \
    --cc=bitcoin-dev@lists.linuxfoundation.org \
    --cc=stick@satoshilabs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox