For the record, strong NACK. My understanding is that this breaks several established SPV implementations (such as early breadwallet for sure and possibly current BRD wallets) and I have yet to see quantitative prioritization or even a rational justification for this change.
Requiring SPV wallets to communicate with trusted nodes is centralization, and breaking functionality and implementations that enable this without a thoroughly researched rationale is highly suspect.On Jul 20, 2019, at 1:46 PM, Matt Corallo via bitcoin-dev <bitcoin-dev@lists.linuxfoundation.org> wrote:Just a quick heads-up for those watching the list who may be using it -in the next Bitcoin Core release bloom filter serving will be turned offby default. This has been a long time coming, it's been an option formany releases and has been a well-known DoS vector for some time.As other DoS vectors have slowly been closed, this has becomeincreasingly an obvious low-hanging fruit. Those who are using it shouldalready have long been filtering for NODE_BLOOM-signaling nodes, and Idon't anticipate those being gone any time particularly soon.See-also PR at https://github.com/bitcoin/bitcoin/pull/16152The release notes will liekly read:P2P Changes------------ The default value for the -peerbloomfilters configuration option (and,thus, NODE_BLOOM support) has been changed to false.This resolves well-known DoS vectors in Bitcoin Core, especially fornodes with spinning disks. It is not anticipated thatthis will result in a significant lack of availability ofNODE_BLOOM-enabled nodes in the coming years, however, clientswhich rely on the availability of NODE_BLOOM-supporting nodes on theP2P network should consider the process of migratingto a more modern (and less trustful and privacy-violating) alternativeover the coming years.Matt_______________________________________________bitcoin-dev mailing listbitcoin-dev@lists.linuxfoundation.orghttps://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev