public inbox for bitcoindev@googlegroups.com
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@exmulti.com>
To: Wladimir <laanwj@gmail.com>
Cc: Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] bitcoin pull requests
Date: Tue, 2 Apr 2013 23:51:45 -0400	[thread overview]
Message-ID: <CA+8xBpcZtsZ=p30hJtqLTBJPEE3eD=gQ+x6bKy46z0hc8XNB1Q@mail.gmail.com> (raw)
In-Reply-To: <CA+s+GJBLUTfu8q2zE4pJ+HO5u-GweGNKZebV=XRhBe7TCPggPg@mail.gmail.com>

On Tue, Apr 2, 2013 at 11:41 PM, Wladimir <laanwj@gmail.com> wrote:
> Maybe now that bitcoin is growing out of the toy phase it's an idea to start
> gpg signing commits, like the Linux kernel
> (https://lwn.net/Articles/466468/).
>
> But I suppose then we can't use github anymore to merge as-is and need
> manual steps?

Correct, that rules out github, AFAICS.

Though, honestly, when I ACK that means I read the code, which is more
important than the author really.  github seems fine for that still,
though I do wonder if there is a race possible,

* sneak uploads innocent branch sneak/bitcoin.git #innocent
* sneak creates pull req
* just before I click "pull", sneak rebases the branch to something evil

-- 
Jeff Garzik
exMULTI, Inc.
jgarzik@exmulti.com



  reply	other threads:[~2013-04-03  3:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-01  8:26 [Bitcoin-development] bitcoin pull requests Melvin Carvalho
2013-04-01 18:28 ` Petr Praus
2013-04-01 21:52   ` Melvin Carvalho
2013-04-01 22:10     ` Will
2013-04-01 22:27       ` Melvin Carvalho
2013-04-01 22:51         ` Roy Badami
2013-04-01 22:54           ` Roy Badami
2013-04-03  3:41             ` Wladimir
2013-04-03  3:51               ` Jeff Garzik [this message]
2013-04-03 15:52                 ` grarpamp
2013-04-03 16:05                   ` Gavin Andresen
2013-04-03 16:23                     ` grarpamp
     [not found]                       ` <CAAS2fgT06RHBO_0stKQAYLPB39ZAzaCVduFZJROjSzXUP4Db+g@mail.gmail.com>
2013-04-03 18:12                         ` grarpamp
2013-04-04  9:11                           ` Mike Hearn
2013-04-04 10:04                             ` Mike Hearn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+8xBpcZtsZ=p30hJtqLTBJPEE3eD=gQ+x6bKy46z0hc8XNB1Q@mail.gmail.com' \
    --to=jgarzik@exmulti.com \
    --cc=bitcoin-development@lists.sourceforge.net \
    --cc=laanwj@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox