public inbox for bitcoindev@googlegroups.com
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@exmulti.com>
To: Michael Offel <Michael.Offel@web.de>
Cc: bitcoin-development@lists.sourceforge.net
Subject: Re: [Bitcoin-development] overall bitcoin client code quality
Date: Sun, 10 Jul 2011 19:31:20 -0400	[thread overview]
Message-ID: <CA+8xBpdqrJxP0VLpX3yk+-u6WL_xqy5zXztznKku_h+eGo1aYQ@mail.gmail.com> (raw)
In-Reply-To: <97305540.4426247.1310337435268.JavaMail.fmail@mwmweb052>

On Sun, Jul 10, 2011 at 6:37 PM, Michael Offel <Michael.Offel@web.de> wrote:
> 1. nearly no code documentation

agreed -- contributions welcome


> 2. isolation of modules

It is a long term goal to move towards 'libbitcoin"

> 3. poor use of threads

agreed -- contributions welcome

> 4. long build times

very low priority.

> 5. style guide

contributions to existing style guide welcome

> 6. hardcoded values

very low priority


> Let me also say that I'm not pointing to someone to do all this. I'm willing to spend a lot of time on this promising project but this kind of cleanup is simply too large for one person who is new to the code.
> My overall suggestion is to begin a complete rewrite, inspired by the old code rather than moving a lot of "known to be somehow functional" around.
> The official Bitcoin client should be some kind of an reference project for other clients and must therefore be extra clean and well documented.
>
> Hopefully I did not hurt someone's feelings.

We know the code isn't what people would prefer, but that's what we've
inherited.  Everybody has suggestions, but given limited development
resources we're swamped as is.  (hence all the "contributions welcome"
responses)

-- 
Jeff Garzik
exMULTI, Inc.
jgarzik@exmulti.com



  parent reply	other threads:[~2011-07-10 23:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-10 22:37 [Bitcoin-development] overall bitcoin client code quality Michael Offel
2011-07-10 23:07 ` Douglas Huff
2011-07-10 23:31 ` Jeff Garzik [this message]
2011-07-10 23:36 ` Matt Corallo
2011-07-11  2:01 ` Luke-Jr
2011-07-12  4:13   ` Alan Grimes
2011-07-12  5:19     ` Jeff Garzik
2011-07-11  9:33 ` Mike Hearn
2011-07-12  3:31   ` Gavin Andresen
2011-07-12  7:21   ` John Smith
2011-07-12 22:50   ` Michael Offel
2011-07-12 21:47 Michael Offel
2011-07-12 23:40 ` Gregory Maxwell
2011-07-13  0:17 ` Matt Corallo
2011-07-13 11:50   ` Mike Hearn
2011-07-13 13:04     ` Andy Parkins
2011-07-13 18:37       ` Luke-Jr
2011-07-13 21:41         ` Andy Parkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+8xBpdqrJxP0VLpX3yk+-u6WL_xqy5zXztznKku_h+eGo1aYQ@mail.gmail.com \
    --to=jgarzik@exmulti.com \
    --cc=Michael.Offel@web.de \
    --cc=bitcoin-development@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox