* [Bitcoin-development] Bug in genbuild.sh ?
@ 2014-11-03 9:16 Francis GASCHET
2014-11-03 10:11 ` Wladimir
0 siblings, 1 reply; 2+ messages in thread
From: Francis GASCHET @ 2014-11-03 9:16 UTC (permalink / raw)
To: bitcoin-development
Hello,
I just compiled bitCoin core on Debian 7.
I got an error message "too many arguments" when executing genuid.sh
I fixed it as shown hereafter and it worked fine.
pcfg:~/bitcoinCore> diff -u shareOLD/genbuild.sh share/genbuild.sh
--- shareOLD/genbuild.sh 2014-11-03 08:32:08.950708258 +0100
+++ share/genbuild.sh 2014-11-03 08:38:44.626698114 +0100
@@ -16,7 +16,7 @@
DESC=""
SUFFIX=""
LAST_COMMIT_DATE=""
-if [ -e "$(which git 2>/dev/null)" -a $(git rev-parse
--is-inside-work-tree 2>/dev/null) = "true" ]; then
+if [ -e "$(which git 2>/dev/null)" -a "$(git rev-parse
--is-inside-work-tree 2>/dev/null)" = "true" ]; then
# clean 'dirty' status of touched files that haven't been modified
git diff >/dev/null 2>/dev/null
Best regards,
--
Francis
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Bitcoin-development] Bug in genbuild.sh ?
2014-11-03 9:16 [Bitcoin-development] Bug in genbuild.sh ? Francis GASCHET
@ 2014-11-03 10:11 ` Wladimir
0 siblings, 0 replies; 2+ messages in thread
From: Wladimir @ 2014-11-03 10:11 UTC (permalink / raw)
To: Francis GASCHET; +Cc: Bitcoin Dev
On Mon, Nov 3, 2014 at 10:16 AM, Francis GASCHET <fg@numlog.fr> wrote:
> Hello,
>
> I just compiled bitCoin core on Debian 7.
> I got an error message "too many arguments" when executing genuid.sh
> I fixed it as shown hereafter and it worked fine.
>
>
> pcfg:~/bitcoinCore> diff -u shareOLD/genbuild.sh share/genbuild.sh
> --- shareOLD/genbuild.sh 2014-11-03 08:32:08.950708258 +0100
> +++ share/genbuild.sh 2014-11-03 08:38:44.626698114 +0100
> @@ -16,7 +16,7 @@
> DESC=""
> SUFFIX=""
> LAST_COMMIT_DATE=""
> -if [ -e "$(which git 2>/dev/null)" -a $(git rev-parse
> --is-inside-work-tree 2>/dev/null) = "true" ]; then
> +if [ -e "$(which git 2>/dev/null)" -a "$(git rev-parse
> --is-inside-work-tree 2>/dev/null)" = "true" ]; then
> # clean 'dirty' status of touched files that haven't been modified
> git diff >/dev/null 2>/dev/null
ACK
FYI there's an issue for this on github:
https://github.com/bitcoin/bitcoin/pull/5141 , but Rebroad's solution
contains a new error. Will merge your patch.
Wladimir
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-03 10:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-03 9:16 [Bitcoin-development] Bug in genbuild.sh ? Francis GASCHET
2014-11-03 10:11 ` Wladimir
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox