From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 7869CBBC for ; Tue, 12 Mar 2019 22:14:25 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 0D8672C4 for ; Tue, 12 Mar 2019 22:14:24 +0000 (UTC) Received: by mail-ed1-f52.google.com with SMTP id e4so3697905edi.3 for ; Tue, 12 Mar 2019 15:14:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=3jr8hu03zH1kZPL8PbjVJKbvZgmFIkTs/shAg8C8l3s=; b=aBGBsdC1cQ1uM26DPlCauMf0Art5XS+gvP+vfErWegL6Ty0kYWYKunAkhMA91pVz3A iH6Cb3ozU8wBxcFBdnLp6LGytrGELS1qdJ6MlqqTxBzlfngXLy8/Z4nE2pqDxdDVXCIu K0oYN1j8IQoqhEOWv2AhlyIAeX7lUGhLRdgXQnbCX9LqCnMEdc1LJS1q/GOkNdSQjCWh N79dIRmrYgvglOM/UXY9L+ISFOjT/sSZ1ygi4DdYjBdV/kh4kWBhQ7nQv6As3dwpuCuw DltXYPkjAWv9kHZFBWidXVkoatemgDBX8z0RSEt7rMKnByuf98RVZLdnCwqUFNCqFmK2 xwnA== X-Gm-Message-State: APjAAAWZCPNlPVuDChrWxmdO2qD5g1morEq5biyGXVgXaIbcqxcCfpfe Dgqn9Zt7cRtrHP/NMCSF2XOtTEi6gy18jqG1v5Ei3w== X-Google-Smtp-Source: APXvYqywktmS0fa0V/lOJwSP7rdss90s1aSRlIsNdX00p8g2nyPFvAfGXaqRI4iI6m6HQGbTSDrDeBXjtG/NqrNhaqc= X-Received: by 2002:a17:906:2001:: with SMTP id 1mr8093403ejo.243.1552428863594; Tue, 12 Mar 2019 15:14:23 -0700 (PDT) MIME-Version: 1.0 References: <78CAF294-56E2-477C-B46F-C65A56357820@sprovoost.nl> In-Reply-To: From: Gregory Maxwell Date: Tue, 12 Mar 2019 22:14:10 +0000 Message-ID: To: Andreas Schildbach , Bitcoin Protocol Discussion Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org X-Mailman-Approved-At: Wed, 13 Mar 2019 00:41:38 +0000 Subject: Re: [bitcoin-dev] Removal of reject network messages from Bitcoin Core (BIP61) X-BeenThere: bitcoin-dev@lists.linuxfoundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Bitcoin Protocol Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Mar 2019 22:14:25 -0000 On Tue, Mar 12, 2019 at 7:45 PM Andreas Schildbach via bitcoin-dev wrote: > These two cases are understood and handled by current code. Generally > the idea is take reject messages serious, but don't overrate the lack > of. Luckily, network confirmations fill the gap. (Yes, a timeout is I'd like to better understand this, but it would be easier to just read the code than ask a bunch of questions. I tried looking for the handling of reject messages in Android Bitcoin Wallet and BitcoinJ and didn't really find and handling other than logging exceptions. Would you mind giving me a couple pointers to where in the code they're handled?