From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jtimon@jtimon.cc>
Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org
	[172.17.192.35])
	by mail.linuxfoundation.org (Postfix) with ESMTPS id 425C797
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Mon, 19 Oct 2015 10:43:08 +0000 (UTC)
X-Greylist: whitelisted by SQLgrey-1.7.6
Received: from mail-lf0-f46.google.com (mail-lf0-f46.google.com
	[209.85.215.46])
	by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 834FFE3
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Mon, 19 Oct 2015 10:43:07 +0000 (UTC)
Received: by lffy185 with SMTP id y185so108233681lff.2
	for <bitcoin-dev@lists.linuxfoundation.org>;
	Mon, 19 Oct 2015 03:43:05 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:mime-version:in-reply-to:references:date
	:message-id:subject:from:to:cc:content-type;
	bh=mIwVELRXnHcf4pKrDbkB7Szk0mMDKJvDtHt1jwMpSeQ=;
	b=g2C7fajosbYu02bg8YU/M+6vao66sHMWFDI4svpEfklVLz3mPYfk3Mn15u1RDUZ0z8
	8UByN5y1P9U1C2DKAJLTlOHGoi1qxVrB9SxdiAHjhHAeLUF/CXM4V26X6mOVarPwM7Hs
	tveGigZh7Wbd2Rbdyo8g9kNRHH3YHE5LLBqSXJiNZgux6Z76qL8InoqVgR44FnlKVow+
	vOL2FiaPfuJPLprLoWdI9Rgm+MUsLu10e8juyh+PAlv7MFdAHgzkgq4mbSZpcDUv2JA9
	t6os6eCfehZsH5wr8AINkDXJ1Qunaiz8GlPHMXVHhldHUs0SHSAXPH2TDOi+51ILyN7t
	suCA==
X-Gm-Message-State: ALoCoQnb3MBmD/FBeWZ1aHNVPO35i7P7U9pWa1UNUqq+zS+IxUnQYUHh2uEghPeTvUTXA1XH1jnk
MIME-Version: 1.0
X-Received: by 10.180.102.195 with SMTP id fq3mr19985034wib.7.1445251385635;
	Mon, 19 Oct 2015 03:43:05 -0700 (PDT)
Received: by 10.194.114.199 with HTTP; Mon, 19 Oct 2015 03:43:05 -0700 (PDT)
In-Reply-To: <878u73hadl.fsf@rustcorp.com.au>
References: <20151003143056.GA27942@muck> <87lhbgn4fa.fsf@rustcorp.com.au>
	<20151008174120.GA9291@muck> <87pp0okeip.fsf@rustcorp.com.au>
	<CAPWm=eUR1fo4iVX=-J7mO34LvT6akRy5=Cxjn7j64PBn+A_oGQ@mail.gmail.com>
	<CADJgMzsvdG2iE=FhYrgKve_JxtMjFVOS4Gx-0Q8GnqDYF_-qOw@mail.gmail.com>
	<87oafzhgat.fsf@rustcorp.com.au> <878u73hadl.fsf@rustcorp.com.au>
Date: Mon, 19 Oct 2015 12:43:05 +0200
Message-ID: <CABm2gDpGUgK5UMqfsZZBfyuxs4hb+N1Y23if_J8EmXisAqiRUA@mail.gmail.com>
From: =?UTF-8?B?Sm9yZ2UgVGltw7Nu?= <jtimon@jtimon.cc>
To: Rusty Russell <rusty@rustcorp.com.au>
Content-Type: text/plain; charset=UTF-8
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW
	autolearn=ham version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
	smtp1.linux-foundation.org
Cc: Bitcoin Dev <bitcoin-dev@lists.linuxfoundation.org>
Subject: Re: [bitcoin-dev] CHECKSEQUENCEVERIFY - We need more usecases to
 motivate the change
X-BeenThere: bitcoin-dev@lists.linuxfoundation.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Bitcoin Development Discussion <bitcoin-dev.lists.linuxfoundation.org>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/bitcoin-dev>,
	<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/bitcoin-dev/>
List-Post: <mailto:bitcoin-dev@lists.linuxfoundation.org>
List-Help: <mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev>,
	<mailto:bitcoin-dev-request@lists.linuxfoundation.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Oct 2015 10:43:08 -0000

On Fri, Oct 16, 2015 at 3:26 AM, Rusty Russell via bitcoin-dev
<bitcoin-dev@lists.linuxfoundation.org> wrote:
> ... Gavin just told me about setmocktime.  That's fast service!

Once more functions (specially consensus-critical functions) take
nTime explicitly as parameter instead of relying on the
library-unfriendly GetAdjustedTime(), then SetMockTime() will be less
necessary for testing. For example, see
https://github.com/jtimon/bitcoin/commit/88a35548518a27c7d24efe064e1bf4e5b3029578#diff-524ba4b43aa70d393ef51ab42a6d25f2L52