public inbox for bitcoindev@googlegroups.com
 help / color / mirror / Atom feed
From: Gavin Andresen <gavinandresen@gmail.com>
To: Gregory Maxwell <gmaxwell@gmail.com>
Cc: Bitcoin Development <bitcoin-development@lists.sourceforge.net>,
	Andreas Schildbach <andreas@schildbach.de>
Subject: Re: [Bitcoin-development] Feedback requested: "reject" p2p message
Date: Tue, 29 Oct 2013 15:37:11 +1000	[thread overview]
Message-ID: <CABsx9T3p6KFc8FiOgBwLtQsmkETE_iUbMhO47pS7J3hi3a9_4w@mail.gmail.com> (raw)
In-Reply-To: <CAAS2fgSuL4f9Sdg2CyK-EuCKK04gD98zHDoKFyTg_Fp_cNiz=A@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]

Thanks for the feedback, everybody, gist updated:
  https://gist.github.com/gavinandresen/7079034

Categories are:

0x01-0x0fProtocol syntax errors0x10-0x1fProtocol semantic errors0x40-0x4fServer
policy rule
<https://gist.github.com/gavinandresen/7079034#rejection-codes-common-to-all-message-types>

RE: why not a varint:  because we're never ever going to run out of reject
codes.  Eight are defined right now, if we ever defined eight more I'd be
surprised.

RE: why not use HTTP codes directly: because we'd be fitting round pegs
into square holes.

-- 
--
Gavin Andresen

[-- Attachment #2: Type: text/html, Size: 2240 bytes --]

  reply	other threads:[~2013-10-29  5:37 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-26  0:34 [Bitcoin-development] Feedback requested: "reject" p2p message Gavin Andresen
2013-10-26  1:01 ` Jean-Paul Kogelman
2013-10-26  2:00   ` Gavin
2013-10-26  4:32     ` kjj
2013-10-27 14:32       ` Mike Hearn
2013-10-27 14:39         ` Luke-Jr
2013-10-27 14:50           ` Mike Hearn
2013-10-30 17:13         ` Gregory Maxwell
2013-10-31 12:01           ` Mike Hearn
2013-10-27 22:52       ` Gavin Andresen
2013-10-28  2:52         ` kjj
2013-10-28  9:26           ` Andreas Schildbach
2013-10-28  9:32             ` Gregory Maxwell
2013-10-29  5:37               ` Gavin Andresen [this message]
2013-10-29  8:55                 ` Warren Togami Jr.
2013-10-29  9:12                   ` Peter Todd
2013-10-29  9:52                 ` Mike Hearn
2013-10-29 10:14                   ` Peter Todd
2013-10-29 11:38                     ` Peter Todd
2013-10-29 12:32                       ` Mike Hearn
2013-10-29 16:35                         ` [Bitcoin-development] On soft-forks and hard-forks Peter Todd
2013-10-30  2:01                         ` [Bitcoin-development] Feedback requested: "reject" p2p message Gavin Andresen
2013-10-30  8:24                           ` Mike Hearn
2013-10-30  9:05                             ` Mark Friedenbach
2013-10-30 10:26                               ` Mike Hearn
2013-10-28  2:59         ` Luke-Jr
2013-10-28  3:02         ` Pieter Wuille

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABsx9T3p6KFc8FiOgBwLtQsmkETE_iUbMhO47pS7J3hi3a9_4w@mail.gmail.com \
    --to=gavinandresen@gmail.com \
    --cc=andreas@schildbach.de \
    --cc=bitcoin-development@lists.sourceforge.net \
    --cc=gmaxwell@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox