Hi Jimmy,

The only time I could see this being a problem is in the case of a fork-coin.

Otherwise the likelihood that two unrelated networks could have a tx with an id that is identical are low.

Everything included in PSBT thus far is info for verifying something helpful, and providing the information needed for signing and verifying what will be signed.

Adding a network section will be the inverse of that. The info doesn't help you verify anything, since I could lie about the network, and you will need to go out and check the network is as the PSBT says it is anyways.

Network is also not needed for signing.

In fact, come to think of it, even if there was a fork-coin incident, even if you were able to separate PSBTs via network info, it won't matter if there's no replay protection anyways, so giving a false sense of security in thinking "I have explicitly stated my network so I should be ok" (developers will think this, I guarantee) is actually a security minus IMO.

Currently BitcoinJS only uses network parameters to allow for the use of addresses in addOutput... but I'm starting to think we should remove it... not sure...

Cheers,

Jon

2019年10月4日(金) 11:04 Jimmy Song via bitcoin-dev <bitcoin-dev@lists.linuxfoundation.org>:

Hey all,

I wanted to propose a new key in the global context for BIP174, Partially-Signed Bitcoin Transactions.

= Rationale

Each signer should make sure that the inputs being referenced in the PSBT exist (with the exception of a Proof-of-Reserves input). In order to do this, it's critical to know which network the coins are on (mainnet or testnet). This could potentially be extended to other networks should they want to use something like PSBT, much in the same way that HD keys from BIP0044 reserved 0' and 1' as coins for mainnet Bitcoin and testnet Bitcoin respectively.

= Proposal

Add the key 0x03 for network in the global key-value store. Value is a variable integer with 0x00 indicating Bitcoin mainnet and 0x01 indicating Bitcoin testnet. Other coins that want to use the PSBT should use the coin network number from SLIP-0044 with the high bit removed.

---------------------------

Best,

Jimmy

_______________________________________________
bitcoin-dev mailing list
bitcoin-dev@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/bitcoin-dev

-----BEGIN PGP PUBLIC KEY BLOCK-----

Comment: http://openpgpjs.org

xsBNBFTmJ8oBB/9rd+7XLxZG/x/KnhkVK2WBG8ySx91fs+qQfHIK1JrakSV3

x6x0cK3XLClASLLDomm7Od3Q/fMFzdwCEqj6z60T8wgKxsjWYSGL3mq8ucdv

iBjC3wGauk5dQKtT7tkCFyQQbX/uMsBM4ccGBICoDmIJlwJIj7fAZVqGxGOM

bO1RhYb4dbQA2qxYP7wSsHJ6/ZNAXyEphOj6blUzdqO0exAbCOZWWF+E/1SC

EuKO4RmL7Imdep7uc2Qze1UpJCZx7ASHl2IZ4UD0G3Qr3pI6/jvNlaqCTa3U

3/YeJwEubFsd0AVy0zs809RcKKgX3W1q+hVDTeWinem9RiOG/vT+Eec/ABEB

AAHNI2tpbm9zaGl0YSA8a2lub3NoaXRham9uYUBnbWFpbC5jb20+wsByBBAB

CAAmBQJU5ifRBgsJCAcDAgkQRB9iZ30dlisEFQgCCgMWAgECGwMCHgEAAC6Z

B/9otobf0ASHYdlUBeIPXdDopyjQhR2RiZGYaS0VZ5zzHYLDDMW6ZIYm5CjO

Fc09ETLGKFxH2RcCOK2dzwz+KRU4xqOrt/l5gyd50cFE1nOhUN9+/XaPgrou

WhyT9xLeGit7Xqhht93z2+VanTtJAG6lWbAZLIZAMGMuLX6sJDCO0GiO5zxa

02Q2D3kh5GL57A5+oVOna12JBRaIA5eBGKVCp3KToT/z48pxBe3WAmLo0zXr

hEgTSzssfb2zTwtB3Ogoedj+cU2bHJvJ8upS/jMr3TcdguySmxJlGpocVC/e

qxq12Njv+LiETOrD8atGmXCnA+nFNljBkz+l6ADl93jHzsBNBFTmJ9EBCACu

Qq9ZnP+aLU/Rt6clAfiHfTFBsJvLKsdIKeE6qHzsU1E7A7bGQKTtLEnhCCQE

W+OQP+sgbOWowIdH9PpwLJ3Op+NhvLlMxRvbT36LwCmBL0yD7bMqxxmmVj8n

vlMMRSe4wDSIG19Oy7701imnHZPm/pnPlneg/Meu/UffpcDWYBbAFX8nrXPY

vkVULcI/qTcCxW/+S9fwoXjQhWHaiJJ6y3cYOSitN31W9zgcMvLwLX3JgDxE

flkwq/M+ZkfCYnS3GAPEt8GkVKy2eHtCJuNkGFlCAmKMX0yWzHRAkqOMN5KP

LFbkKY2GQl13ztWp82QYJZpj5af6dmyUosurn6AZABEBAAHCwF8EGAEIABMF

AlTmJ9QJEEQfYmd9HZYrAhsMAABKbgf/Ulu5JAk4fXgH0DtkMmdkFiKEFdkW

0Wkw7Vhd5eZ4NzeP9kOkD01OGweT9hqzwhfT2CNXCGxh4UnvEM1ZMFypIKdq

0XpLLJMrDOQO021UjAa56vHZPAVmAM01z5VzHJ7ekjgwrgMLmVkm0jWKEKaO

n/MW7CyphG7QcZ6cJX2f6uJcekBlZRw9TNYRnojMjkutlOVhYJ3J78nc/k0p

kcgV63GB6D7wHRF4TVe4xIBqKpbBhhN+ISwFN1z+gx3lfyRMSmiTSrGdKEQe

XSIQKG8XZQZUDhLNkqPS+7EMV1g7+lOfT4GhLL68dUXDa1e9YxGH6zkpVECw

Spe3vsHZr6CqFg==

=/vUJ

-----END PGP PUBLIC KEY BLOCK-----