From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1VSJ4y-0000Ib-6x for bitcoin-development@lists.sourceforge.net; Sat, 05 Oct 2013 04:02:56 +0000 Received-SPF: pass (sog-mx-4.v43.ch3.sourceforge.com: domain of gmail.com designates 209.85.192.181 as permitted sender) client-ip=209.85.192.181; envelope-from=wtogami@gmail.com; helo=mail-pd0-f181.google.com; Received: from mail-pd0-f181.google.com ([209.85.192.181]) by sog-mx-4.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1VSJ4u-0005cf-9b for bitcoin-development@lists.sourceforge.net; Sat, 05 Oct 2013 04:02:56 +0000 Received: by mail-pd0-f181.google.com with SMTP id g10so4849527pdj.12 for ; Fri, 04 Oct 2013 21:02:46 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.68.4.232 with SMTP id n8mr18178937pbn.9.1380945766183; Fri, 04 Oct 2013 21:02:46 -0700 (PDT) Received: by 10.66.158.129 with HTTP; Fri, 4 Oct 2013 21:02:45 -0700 (PDT) In-Reply-To: References: Date: Fri, 4 Oct 2013 18:02:45 -1000 Message-ID: From: "Warren Togami Jr." To: Gavin Andresen Content-Type: multipart/alternative; boundary=bcaec5215b07d8fe5604e7f67d55 X-Spam-Score: -0.6 (/) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.192.181 listed in list.dnswl.org] -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (wtogami[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: doubleclick.net] 1.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1VSJ4u-0005cf-9b Cc: Bitcoin Dev Subject: Re: [Bitcoin-development] Code review X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Oct 2013 04:02:56 -0000 --bcaec5215b07d8fe5604e7f67d55 Content-Type: text/plain; charset=UTF-8 https://www.kernel.org/doc/Documentation/SubmittingPatches Read the section under "14) Using Reported-by:, Tested-by:, Reviewed-by: and Suggested-by:". That might be helpful in our process too? Warren On Fri, Oct 4, 2013 at 4:31 PM, Gavin Andresen wrote: > On Fri, Oct 4, 2013 at 8:30 PM, Mike Hearn wrote: > >> I'd like to make a small request - when submitting large, complex pieces >> of work for review, please either submit it as one giant squashed change, >> or be an absolute fascist about keeping commits logically clean and >> separated. >> > > I'll try harder to be a fascist (it doesn't come naturally to me). HUGE > thanks for taking the time to review the fee changes in detail. > > RE: using Review Board: > > I'm all for using better tools, if they will actually get used. If a > potential reviewer has to sign up to create a Review Board account or learn > Yet Another Tool, then I think it would be counter-productive: we'd just > make the pool of reviewers even smaller than it already is. > > Are there good examples of other open source software projects > successfully incentivizing review that we can copy? > > For example, I'm wondering if maybe for the 0.9 release and onwards the > "Thank you" section should thank only people who have significantly helped > test or review other people's code. > > -- > -- > Gavin Andresen > > > > ------------------------------------------------------------------------------ > October Webinars: Code for Performance > Free Intel webinars can help you accelerate application performance. > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most > from > the latest Intel processors and coprocessors. See abstracts and register > > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk > _______________________________________________ > Bitcoin-development mailing list > Bitcoin-development@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/bitcoin-development > > --bcaec5215b07d8fe5604e7f67d55 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
https://www.kernel.org/doc/Documentation/SubmittingPatches=
Read the section under "14) Using Reported-by:, Tested-by:, Reviewed-by: and Sugge= sted-by:". That might be helpful in our process too?

Warren


On = Fri, Oct 4, 2013 at 4:31 PM, Gavin Andresen <gavinandresen@gmail.c= om> wrote:
On Fri, O= ct 4, 2013 at 8:30 PM, Mike Hearn <mike@plan99.net> wrote:
I'd like to make a small request - when submittin= g large, complex pieces of work for review, please either submit it as one = giant squashed change, or be an absolute fascist about keeping commits logi= cally clean and separated.

I'll try harder to be a fa= scist (it doesn't come naturally to me). HUGE thanks for taking the tim= e to review the fee changes in detail.

RE: using R= eview Board:

I'm all for using better tools, if they will actual= ly get used. If a potential reviewer has to sign up to create a Review Boar= d account or learn Yet Another Tool, then I think it would be counter-produ= ctive: =C2=A0we'd just make the pool of reviewers even smaller than it = already is.

Are there good examples of other open source software p= rojects successfully incentivizing review that we can copy?

<= /div>
For example, I'm wondering if maybe for the 0.9 release and o= nwards the "Thank you" section should thank only people who have = significantly helped test or review other people's code.
--
--
Gavin Andresen


-----------------------------------------------------------------------= -------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most fr= om
the latest Intel processors and coprocessors. See abstracts and register &g= t;
http://pubads.g.doubleclick.net/gam= pad/clk?id=3D60134791&iu=3D/4140/ostg.clktrk
___________________= ____________________________
Bitcoin-development mailing list
Bitcoin-develo= pment@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bitcoin-de= velopment


--bcaec5215b07d8fe5604e7f67d55--