From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from <wtogami@gmail.com>) id 1VSJ4y-0000Ib-6x for bitcoin-development@lists.sourceforge.net; Sat, 05 Oct 2013 04:02:56 +0000 Received-SPF: pass (sog-mx-4.v43.ch3.sourceforge.com: domain of gmail.com designates 209.85.192.181 as permitted sender) client-ip=209.85.192.181; envelope-from=wtogami@gmail.com; helo=mail-pd0-f181.google.com; Received: from mail-pd0-f181.google.com ([209.85.192.181]) by sog-mx-4.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1VSJ4u-0005cf-9b for bitcoin-development@lists.sourceforge.net; Sat, 05 Oct 2013 04:02:56 +0000 Received: by mail-pd0-f181.google.com with SMTP id g10so4849527pdj.12 for <bitcoin-development@lists.sourceforge.net>; Fri, 04 Oct 2013 21:02:46 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.68.4.232 with SMTP id n8mr18178937pbn.9.1380945766183; Fri, 04 Oct 2013 21:02:46 -0700 (PDT) Received: by 10.66.158.129 with HTTP; Fri, 4 Oct 2013 21:02:45 -0700 (PDT) In-Reply-To: <CABsx9T1Q85usG4mhgLJTnK5pMUDwd1Ek3FmG0Z+-3vxg80xX0Q@mail.gmail.com> References: <CANEZrP1Sd8cK2YUr4OSvnOxEJrbWpmfdpor-qbap1f98tGqPwg@mail.gmail.com> <CABsx9T1Q85usG4mhgLJTnK5pMUDwd1Ek3FmG0Z+-3vxg80xX0Q@mail.gmail.com> Date: Fri, 4 Oct 2013 18:02:45 -1000 Message-ID: <CAEz79PrCYfVpTrvOBsCE3BNN_vhYN0oh5nhfEFX-t+x34Y5KMg@mail.gmail.com> From: "Warren Togami Jr." <wtogami@gmail.com> To: Gavin Andresen <gavinandresen@gmail.com> Content-Type: multipart/alternative; boundary=bcaec5215b07d8fe5604e7f67d55 X-Spam-Score: -0.6 (/) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.192.181 listed in list.dnswl.org] -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (wtogami[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: doubleclick.net] 1.0 HTML_MESSAGE BODY: HTML included in message -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1VSJ4u-0005cf-9b Cc: Bitcoin Dev <bitcoin-development@lists.sourceforge.net> Subject: Re: [Bitcoin-development] Code review X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: <bitcoin-development.lists.sourceforge.net> List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>, <mailto:bitcoin-development-request@lists.sourceforge.net?subject=unsubscribe> List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=bitcoin-development> List-Post: <mailto:bitcoin-development@lists.sourceforge.net> List-Help: <mailto:bitcoin-development-request@lists.sourceforge.net?subject=help> List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/bitcoin-development>, <mailto:bitcoin-development-request@lists.sourceforge.net?subject=subscribe> X-List-Received-Date: Sat, 05 Oct 2013 04:02:56 -0000 --bcaec5215b07d8fe5604e7f67d55 Content-Type: text/plain; charset=UTF-8 https://www.kernel.org/doc/Documentation/SubmittingPatches Read the section under "14) Using Reported-by:, Tested-by:, Reviewed-by: and Suggested-by:". That might be helpful in our process too? Warren On Fri, Oct 4, 2013 at 4:31 PM, Gavin Andresen <gavinandresen@gmail.com>wrote: > On Fri, Oct 4, 2013 at 8:30 PM, Mike Hearn <mike@plan99.net> wrote: > >> I'd like to make a small request - when submitting large, complex pieces >> of work for review, please either submit it as one giant squashed change, >> or be an absolute fascist about keeping commits logically clean and >> separated. >> > > I'll try harder to be a fascist (it doesn't come naturally to me). HUGE > thanks for taking the time to review the fee changes in detail. > > RE: using Review Board: > > I'm all for using better tools, if they will actually get used. If a > potential reviewer has to sign up to create a Review Board account or learn > Yet Another Tool, then I think it would be counter-productive: we'd just > make the pool of reviewers even smaller than it already is. > > Are there good examples of other open source software projects > successfully incentivizing review that we can copy? > > For example, I'm wondering if maybe for the 0.9 release and onwards the > "Thank you" section should thank only people who have significantly helped > test or review other people's code. > > -- > -- > Gavin Andresen > > > > ------------------------------------------------------------------------------ > October Webinars: Code for Performance > Free Intel webinars can help you accelerate application performance. > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most > from > the latest Intel processors and coprocessors. See abstracts and register > > http://pubads.g.doubleclick.net/gampad/clk?id=60134791&iu=/4140/ostg.clktrk > _______________________________________________ > Bitcoin-development mailing list > Bitcoin-development@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/bitcoin-development > > --bcaec5215b07d8fe5604e7f67d55 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><a href=3D"https://www.kernel.org/doc/Documentation/Submit= tingPatches">https://www.kernel.org/doc/Documentation/SubmittingPatches</a>= <br><div>Read the section under "<span style=3D"color:rgb(0,0,0);white= -space:pre-wrap">14) Using Reported-by:, Tested-by:, Reviewed-by: and Sugge= sted-by:". That might be helpful in our process too?</span></div> <div><span style=3D"color:rgb(0,0,0);white-space:pre-wrap"><br></span></div= ><div><span style=3D"color:rgb(0,0,0);white-space:pre-wrap">Warren</span></= div></div><div class=3D"gmail_extra"><br><br><div class=3D"gmail_quote">On = Fri, Oct 4, 2013 at 4:31 PM, Gavin Andresen <span dir=3D"ltr"><<a href= =3D"mailto:gavinandresen@gmail.com" target=3D"_blank">gavinandresen@gmail.c= om</a>></span> wrote:<br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"><div dir=3D"ltr"><div class=3D"im">On Fri, O= ct 4, 2013 at 8:30 PM, Mike Hearn <span dir=3D"ltr"><<a href=3D"mailto:m= ike@plan99.net" target=3D"_blank">mike@plan99.net</a>></span> wrote:<br> </div><div class=3D"gmail_extra"><div class=3D"gmail_quote"><div class=3D"i= m"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left= :1px #ccc solid;padding-left:1ex"> <div dir=3D"ltr"><div>I'd like to make a small request - when submittin= g large, complex pieces of work for review, please either submit it as one = giant squashed change, or be an absolute fascist about keeping commits logi= cally clean and separated.</div> </div></blockquote><div><br></div></div><div>I'll try harder to be a fa= scist (it doesn't come naturally to me). HUGE thanks for taking the tim= e to review the fee changes in detail.</div><div><br></div><div>RE: using R= eview Board:</div> <div><br></div><div>I'm all for using better tools, if they will actual= ly get used. If a potential reviewer has to sign up to create a Review Boar= d account or learn Yet Another Tool, then I think it would be counter-produ= ctive: =C2=A0we'd just make the pool of reviewers even smaller than it = already is.</div> <div><br></div><div>Are there good examples of other open source software p= rojects successfully incentivizing review that we can copy?</div><div><br><= /div><div>For example, I'm wondering if maybe for the 0.9 release and o= nwards the "Thank you" section should thank only people who have = significantly helped test or review other people's code.</div> <span class=3D"HOEnZb"><font color=3D"#888888"> </font></span></div><span class=3D"HOEnZb"><font color=3D"#888888"><div><br= ></div>-- <br>--<br>Gavin Andresen<br> </font></span></div><div class=3D"gmail_extra"><br></div></div> <br>-----------------------------------------------------------------------= -------<br> October Webinars: Code for Performance<br> Free Intel webinars can help you accelerate application performance.<br> Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most fr= om<br> the latest Intel processors and coprocessors. See abstracts and register &g= t;<br> <a href=3D"http://pubads.g.doubleclick.net/gampad/clk?id=3D60134791&iu= =3D/4140/ostg.clktrk" target=3D"_blank">http://pubads.g.doubleclick.net/gam= pad/clk?id=3D60134791&iu=3D/4140/ostg.clktrk</a><br>___________________= ____________________________<br> Bitcoin-development mailing list<br> <a href=3D"mailto:Bitcoin-development@lists.sourceforge.net">Bitcoin-develo= pment@lists.sourceforge.net</a><br> <a href=3D"https://lists.sourceforge.net/lists/listinfo/bitcoin-development= " target=3D"_blank">https://lists.sourceforge.net/lists/listinfo/bitcoin-de= velopment</a><br> <br></blockquote></div><br></div> --bcaec5215b07d8fe5604e7f67d55--