public inbox for bitcoindev@googlegroups.com
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@bitpay.com>
To: "Warren Togami Jr." <wtogami@gmail.com>
Cc: "bitcoin-development@lists.sourceforge.net"
	<bitcoin-development@lists.sourceforge.net>
Subject: Re: [Bitcoin-development] bitcoind stops responding
Date: Tue, 1 Oct 2013 03:26:59 +0200	[thread overview]
Message-ID: <CAJHLa0NX-hfRu1YOK1tqb5j_Y8QxC6YZPjj7rc+3NjqNxrH4qg@mail.gmail.com> (raw)
In-Reply-To: <CAEz79PrGKH27GkDkM2whAdOYYj6-hc954Z=9v1GanBRQA3chvA@mail.gmail.com>

On Mon, Sep 30, 2013 at 11:01 PM, Warren Togami Jr. <wtogami@gmail.com> wrote:
> 0.8.2 apparently was the first Bitcoin version to support RPC keepalive.

No, this is not correct at all.  RPC keepalive was present in 0.7.0,
possibly earlier.

Come on, it took a 30 second 'git checkout' session to verify this.


> With the 4 RPC thread limit, four keepalive connections will exhaust all four and prevent further connections.

I was about to flame you with a "WTF is this fiction?" but it seems
true: 21eb5ada introduces this.

Unfortunately, it does so erroneously, introducing clearly buggy
behavior that did not exist with the thread-per-connection code that
provided keep-alive before commit 21eb5ada.

In my opinion, 21eb5ada half-changed the RPC code from
thread-per-connection to a worker-group model, without considering all
the consequences.

-- 
Jeff Garzik
Senior Software Engineer and open source evangelist
BitPay, Inc.      https://bitpay.com/



  parent reply	other threads:[~2013-10-01  1:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-30 20:44 [Bitcoin-development] bitcoind stops responding slush
2013-09-30 21:01 ` Warren Togami Jr.
2013-09-30 22:00   ` Fatima Castiglione Maldonado 发
2013-09-30 22:08     ` Gregory Maxwell
2013-10-01  0:05       ` Fatima Castiglione Maldonado 发
2013-10-01  1:26   ` Jeff Garzik [this message]
2013-10-01  0:20 ` Chris Double
2013-10-01  1:17 ` Jeff Garzik
2013-10-01  8:58   ` slush
2013-10-04  6:22     ` Gavin Andresen
2013-10-04 15:05       ` Jeff Garzik
2013-10-01  4:03 ` Olivier Langlois
2013-10-01  7:10   ` Olivier Langlois
2013-10-01 14:17     ` Jeff Garzik
2013-10-02  3:20       ` Olivier Langlois
2013-10-04  3:52         ` Olivier Langlois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJHLa0NX-hfRu1YOK1tqb5j_Y8QxC6YZPjj7rc+3NjqNxrH4qg@mail.gmail.com \
    --to=jgarzik@bitpay.com \
    --cc=bitcoin-development@lists.sourceforge.net \
    --cc=wtogami@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox