From: John Smith <witchspace81@gmail.com>
To: Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
Subject: [Bitcoin-development] Fwd: bitcoin scope issue in main.cpp
Date: Sun, 23 Oct 2011 11:56:00 +0200 [thread overview]
Message-ID: <CAJNQ0ssSQ0egHZ8YWFzrGv=LjfWQqV9V7qSeB01Zg2C4-LSZGQ@mail.gmail.com> (raw)
In-Reply-To: <CA+s+GJBo90gH4pRx7+vnHgy5y6bWF7My69jNj6J-RHw7bBqH8g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 672 bytes --]
FYI
It's in a disabled feature (replacement), so I'm not sure how important this
is, but it doesn't look good.
---------- Forwarded message ----------
From: Dean Gores <dmgores@gmail.com>
Date: Sun, Oct 23, 2011 at 11:15 AM
Subject: bitcoin scope issue in main.cpp
To: laanwj@gmail.com
You have "i" and "output" declared in the same scope in "main.cpp",
AcceptToMemoryPool. Below is the offending code.
for (int i = 0; i < vin.size(); i++)
{
COutPoint outpoint = vin[i].prevout;
if (!mapNextTx.count(outpoint) ||
mapNextTx[outpoint].ptx != ptxOld)
return false;
}
Cheers,
Dean Gores
[-- Attachment #2: Type: text/html, Size: 1102 bytes --]
next parent reply other threads:[~2011-10-23 9:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAMm66_=eqw9VqYrs5kv_i1di1FmDtP8X1dgBH90N0CuVvZswMA@mail.gmail.com>
[not found] ` <CA+s+GJBo90gH4pRx7+vnHgy5y6bWF7My69jNj6J-RHw7bBqH8g@mail.gmail.com>
2011-10-23 9:56 ` John Smith [this message]
2011-10-23 20:51 ` [Bitcoin-development] Fwd: bitcoin scope issue in main.cpp theymos
2011-10-24 5:02 ` John Smith
2011-10-24 14:31 ` Amir Taaki
2011-10-24 18:11 ` John Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJNQ0ssSQ0egHZ8YWFzrGv=LjfWQqV9V7qSeB01Zg2C4-LSZGQ@mail.gmail.com' \
--to=witchspace81@gmail.com \
--cc=bitcoin-development@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox