public inbox for bitcoindev@googlegroups.com
 help / color / mirror / Atom feed
From: John Smith <witchspace81@gmail.com>
To: Bitcoin Dev <bitcoin-development@lists.sourceforge.net>
Subject: [Bitcoin-development] "To:" addresses missing
Date: Tue, 26 Jul 2011 14:41:07 +0000	[thread overview]
Message-ID: <CAJNQ0steQtptz1SP+u7nK5GqmEF1GJTYGuys0n0V5sAhh9zobg@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 941 bytes --]

I first thought it was a problem in my UI, after syncing to the latest git
version. But the following screenshot says enough:

http://img24.imageshack.us/img24/7363/screencpf.png

The address are also missing in the detailed transaction view. It appears
that the problem is in script.cpp:

        BOOST_FOREACH(PAIRTYPE(opcodetype, valtype)& item, vSolution)
        {
            uint160 hash160;
            if (item.first == OP_PUBKEY)
                addressRet.SetPubKey(item.second);
            else if (item.first == OP_PUBKEYHASH)
                addressRet.SetHash160((uint160)item.second);
            if (keystore == NULL || keystore->HaveKey(addressRet))
                return true;
        }

It will only return "true" on keys that are in the keystore (your own
private keys...). After commenting out the "if (keystore == NULL ..." line,
the display is fixed.

But that simple solution might have impact somewhere else.

JS

[-- Attachment #2: Type: text/html, Size: 1115 bytes --]

                 reply	other threads:[~2011-07-26 14:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJNQ0steQtptz1SP+u7nK5GqmEF1GJTYGuys0n0V5sAhh9zobg@mail.gmail.com \
    --to=witchspace81@gmail.com \
    --cc=bitcoin-development@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox