public inbox for bitcoindev@googlegroups.com
 help / color / mirror / Atom feed
From: Felix Wolfsteller <felix.wolfsteller@gmail.com>
To: bitcoin-dev@lists.linuxfoundation.org
Subject: [bitcoin-dev] Update links (use ssl-variant) to opensource.org/[..x..]MIT ?
Date: Thu, 4 Jan 2018 11:08:08 +0100	[thread overview]
Message-ID: <CALHCSvOn8YxFqGu4yXDPnFunNzmy=cmdwKBNmAL45Ymta3REig@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1091 bytes --]

Hey there
Most source files contain the "default" copyright-header (also build by a
script in devtools/copyright_header.py), which points out that the MIT
license can be found in the COPYING file or at
http://www.opensource.org/licenses/mit-license.php.

However, the provided link is 1) using http where it could use https, 2)
resulting in a redirect (https://opensource.org/licenses/mit-license.php)
anyway.
I am strongly in favor of using https where possible (I guess there are
many other non-ssl links in the code base, but lets tackle the easier ones
first).

I propose that I
1) create a issue on github,
2) `sed -i` the relevant links,
3) create a PR on github,
4) come back to the mailing list.

This change would affect a few hundred files I guess.

A question remaining is this change would require a
copyright-year-extension (to 2018), too.

An example header can be seen e.g. here
https://github.com/bitcoin/bitcoin/blob/a9a49e6e7e8df13d80a6dc3245ce7ef041942e9b/src/consensus/merkle.cpp#L3

I'd be happy about quick feedback - do not know the culture here, yet.

Have fun
Felix

[-- Attachment #2: Type: text/html, Size: 2322 bytes --]

             reply	other threads:[~2018-01-04 10:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-04 10:08 Felix Wolfsteller [this message]
2018-01-15 14:33 ` [bitcoin-dev] Update links (use ssl-variant) to opensource.org/[..x..]MIT ? Felix Wolfsteller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALHCSvOn8YxFqGu4yXDPnFunNzmy=cmdwKBNmAL45Ymta3REig@mail.gmail.com' \
    --to=felix.wolfsteller@gmail.com \
    --cc=bitcoin-dev@lists.linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox