From: Chris Double <chris.double@double.co.nz>
To: bitcoin-development@lists.sourceforge.net
Subject: Re: [Bitcoin-development] Transaction limit size in CWallet::CreateTransaction
Date: Sun, 4 Sep 2011 02:16:40 +1200 [thread overview]
Message-ID: <CALn1vHHZAfE+phvcaSQNaaAgWPjVGfhOXKyp+hofrYgwAKBR9w@mail.gmail.com> (raw)
In-Reply-To: <CALn1vHHynfb-u8fSwsStA=e5vR6x-e3yA44Z9Mt9A+AgO1+ezQ@mail.gmail.com>
On Sun, Sep 4, 2011 at 1:52 AM, Chris Double <chris.double@double.co.nz> wrote:
> So was the intent to use the CWalletTxn size, and the casting is
> superfluous, or was it supposed to be the CTransaction* portion and
> the cast is an incorrect way of doing that? Or am I suffering from
> late night programmer syndrome and reading it wrong?
After a discussion on #bitcoin-dev it is indeed the latter. I was
under the mistaken believe that the GetSerializeSize method in
CTransaction and CWalletTxn were virtual, which would result in the
behavior I was thinking of. But they're not so it works. Please
disregard!
Chris.
--
http://www.bluishcoder.co.nz
prev parent reply other threads:[~2011-09-03 14:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-03 13:52 [Bitcoin-development] Transaction limit size in CWallet::CreateTransaction Chris Double
2011-09-03 14:16 ` Chris Double [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALn1vHHZAfE+phvcaSQNaaAgWPjVGfhOXKyp+hofrYgwAKBR9w@mail.gmail.com \
--to=chris.double@double.co.nz \
--cc=bitcoin-development@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox