From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1SjCDn-00009o-Mq for bitcoin-development@lists.sourceforge.net; Mon, 25 Jun 2012 16:33:03 +0000 Received-SPF: pass (sog-mx-1.v43.ch3.sourceforge.com: domain of gmail.com designates 74.125.82.175 as permitted sender) client-ip=74.125.82.175; envelope-from=mh.in.england@gmail.com; helo=mail-we0-f175.google.com; Received: from mail-we0-f175.google.com ([74.125.82.175]) by sog-mx-1.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1SjCDm-0001IY-Kd for bitcoin-development@lists.sourceforge.net; Mon, 25 Jun 2012 16:33:03 +0000 Received: by werg55 with SMTP id g55so3210827wer.34 for ; Mon, 25 Jun 2012 09:32:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.142.200 with SMTP id i50mr7234606wej.47.1340641976446; Mon, 25 Jun 2012 09:32:56 -0700 (PDT) Sender: mh.in.england@gmail.com Received: by 10.216.254.232 with HTTP; Mon, 25 Jun 2012 09:32:56 -0700 (PDT) In-Reply-To: References: <4FE0D167.7030506@justmoon.de> <20120620113744.GA14695@vps7135.xlshosting.net> Date: Mon, 25 Jun 2012 18:32:56 +0200 X-Google-Sender-Auth: 6l1AmiWMi4jCYgh23gTbfDvCd2A Message-ID: From: Mike Hearn To: Pieter Wuille Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -1.5 (-) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (mh.in.england[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1SjCDm-0001IY-Kd Cc: bitcoin-development@lists.sourceforge.net Subject: Re: [Bitcoin-development] LevelDB benchmarking X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jun 2012 16:33:03 -0000 I've added some more commits: https://github.com/mikehearn/bitcoin/commits/leveldb It's still not ready for a pull req but is a lot closer: 1) Auto-migration is there but not well tested enough (I only tested with empty wallets). 2) Migration progress UI is there so you have something to watch for the few minutes it takes. Script execution is disabled during migration 3) LevelDB source is checked in to the main tree, bitcoin-qt.pro updated to use it 4) LevelDB is conditionally compiled so if there's some unexpected issue or regression on some platform it can be switched back to BDB Still to go: 1) More testing, eg, with actual wallets :-) 2) Update the non-Qt makefiles 3) On Windows it's currently de-activated due to some missing files from leveldb + I didn't test it If you want to help out, some testing and makefile work would be useful. I may not get a chance to work on this again until next week. On Wed, Jun 20, 2012 at 2:41 PM, Mike Hearn wrote: >> Two days ago on #bitcoin-dev: >> 21:01:19< sipa> what was CTxDB::ReadOwnerTxes ever used for? >> 21:01:31< sipa> maybe it predates the wallet logic >> >> (read: it's not used anywhere in the code, and apparently wasn't ever, even in 0.1.5) > > Great, in that case Stefan is right and I'll delete that code when I > next work on the patch.