From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sog-mx-2.v43.ch3.sourceforge.com ([172.29.43.192] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1VS4H6-0007BO-DG for bitcoin-development@lists.sourceforge.net; Fri, 04 Oct 2013 12:14:28 +0000 Received-SPF: pass (sog-mx-2.v43.ch3.sourceforge.com: domain of gmail.com designates 209.85.214.41 as permitted sender) client-ip=209.85.214.41; envelope-from=mh.in.england@gmail.com; helo=mail-bk0-f41.google.com; Received: from mail-bk0-f41.google.com ([209.85.214.41]) by sog-mx-2.v43.ch3.sourceforge.com with esmtps (TLSv1:RC4-SHA:128) (Exim 4.76) id 1VS4H3-0001hL-RK for bitcoin-development@lists.sourceforge.net; Fri, 04 Oct 2013 12:14:28 +0000 Received: by mail-bk0-f41.google.com with SMTP id na10so1549282bkb.28 for ; Fri, 04 Oct 2013 05:14:19 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.205.14.69 with SMTP id pp5mr12751114bkb.14.1380888859293; Fri, 04 Oct 2013 05:14:19 -0700 (PDT) Sender: mh.in.england@gmail.com Received: by 10.204.237.74 with HTTP; Fri, 4 Oct 2013 05:14:19 -0700 (PDT) In-Reply-To: <20131004115300.GA22215@savin> References: <20131004115300.GA22215@savin> Date: Fri, 4 Oct 2013 14:14:19 +0200 X-Google-Sender-Auth: 6PZi2aTMHwI35YK3bjASfjzWgX4 Message-ID: From: Mike Hearn To: Peter Todd Content-Type: multipart/alternative; boundary=20cf30223a83ef00a904e7e93d54 X-Spam-Score: -0.5 (/) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -1.5 SPF_CHECK_PASS SPF reports sender host as permitted sender for sender-domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (mh.in.england[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: petertodd.org] 1.0 HTML_MESSAGE BODY: HTML included in message 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1VS4H3-0001hL-RK Cc: Bitcoin Dev Subject: Re: [Bitcoin-development] Code review X-BeenThere: bitcoin-development@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Oct 2013 12:14:28 -0000 --20cf30223a83ef00a904e7e93d54 Content-Type: text/plain; charset=UTF-8 On Fri, Oct 4, 2013 at 1:53 PM, Peter Todd wrote: > When I'm reviewing multiple commit pull-requests and want to see every > change made, I always either click on the "Files Changed" tab on github, > which collapses every commit into a single diff, or do the equivalent > with git log. > > Why doesn't that work for you? > The files changed tab definitely works better for reading. In the past comments I put there have disappeared, but I think that can also be true of comments put on the individual commit reviews (which is another issue with github, but it's unrelated to how the commits are presented). So I have lost trust in doing reviews that way. It does make things easier to read though. One advantage of using github is that they're an independent third > party; we should think carefully about the risks of furthering the > impression that Bitcoin development is a closed process by moving the > code review it to a server that we control with explicit review groups. > I guess anyone would be able to sign up and comment. --20cf30223a83ef00a904e7e93d54 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Fri, Oct 4, 2013 at 1:53 PM, Peter Todd <pete@peterto= dd.org> wrote:
When I'm reviewing multiple commit pull-requests and want to = see every
change made, I always either click on the "Files Changed" tab on = github,
which collapses every commit into a single diff, or do the equivalent
with git log.

Why doesn't that work for you?

The = files changed tab definitely works better for reading. In the past comments= I put there have disappeared, but I think that can also be true of comment= s put on the individual commit reviews (which is another issue with github,= but it's unrelated to how the commits are presented). So I have lost t= rust in doing reviews that way. It does make things easier to read though.<= /div>

One advantage of usin= g github is that they're an independent third
party; we should think carefully about the risks of furthering the
impression that Bitcoin development is a closed process by moving the
code review it to a server that we control with explicit review groups.
=

I guess anyone would be able to sign up an= d comment.

--20cf30223a83ef00a904e7e93d54--