From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 3B9A93661 for ; Wed, 13 Mar 2019 14:42:09 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id BE44B12E for ; Wed, 13 Mar 2019 14:42:08 +0000 (UTC) Received: by mail-ed1-f50.google.com with SMTP id p27so1740297edc.6 for ; Wed, 13 Mar 2019 07:42:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RfZl2dGSxXjYxG8r8ult5UjpVgIjgN8LpIfdiqwTBJE=; b=IvQ6CkqNIJS5C48GfXKmnmtnw18UNi2+HJqJPiRG3xJ5msnT9PSNYmipUbX2NQiQmw txvktf27Y744pu1yxHsz9BbdegpRPjjD+p7wCYmVTWm7evVmA8WE6+WN1DZUzjZZoCd1 S+v/a4BowyFLdsEXjnjhtlhxpcu4wvscY30xJpG1RZyzvaEXqONA2LB8VGlbwCcCZRvk gp2YO4et5sqRdpduh+tTB+HFqyQrAUYeaD6V+ZO+cCe6mYhgR+ATuEZm6Hzj4tllK6sd w1/YRo2x31TU0WYhUeU4d8pR3uzE2xUEegHb9KCPfKeHDgjJu29fNXUlq6muExKN6Ejk Vq1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RfZl2dGSxXjYxG8r8ult5UjpVgIjgN8LpIfdiqwTBJE=; b=SpHAEn5454RSEGFK9bvDavhjwYmjd4N/Kt3l1WotTMxcmH7arW0SScW1fLyLIwMJJj 0voOfUFiJiTilUp5HlobsPIg2sTEBo7KmKoxz76iFzLZkNanhwbtc1a2T3WWnoL4bQBa 0ZibL+FUbAxK2U4xF/UkSvTiWAcVjq8pRBZeA6yEmYr66OB3sJMZMrmABbqPT82pWYXy m+MsD/ru9WlgV5nR/xb6Y7QEeLsvn9Tl/jpJ39N/V6wpK8Ub5QDfkL70J2Q55vIQJd3l p9K1SOymd4UeTGWhSEZzxncTdiUk5QT7rYxjeI/aaKys7WOcCoXzjCPYQvSIqxDunIWQ WUEA== X-Gm-Message-State: APjAAAX852AP5gxBv7AfQl4FzDR4kBIl49zdwL1Taaj76dGzVAZhdZ4a bavYshAip1Lc/b15uLIDXoX0ZFml2l7pXC2JnXY= X-Google-Smtp-Source: APXvYqyL417+jfUrO8M7Neog4cp/F44qXLSYO8X+k3MlG+gZDHJ5BfBP+JX1dF/sBVvuNZ8fPe2cWHpJNJrZ6yoTnk0= X-Received: by 2002:a50:b6e6:: with SMTP id f35mr8159399ede.94.1552488127319; Wed, 13 Mar 2019 07:42:07 -0700 (PDT) MIME-Version: 1.0 References: <78CAF294-56E2-477C-B46F-C65A56357820@sprovoost.nl> In-Reply-To: From: Oscar Guindzberg Date: Wed, 13 Mar 2019 11:41:50 -0300 Message-ID: To: Gregory Maxwell , Bitcoin Protocol Discussion Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org X-Mailman-Approved-At: Wed, 13 Mar 2019 22:15:28 +0000 Cc: Andreas Schildbach Subject: Re: [bitcoin-dev] Removal of reject network messages from Bitcoin Core (BIP61) X-BeenThere: bitcoin-dev@lists.linuxfoundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Bitcoin Protocol Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Mar 2019 14:42:09 -0000 > I'd like to better understand this, but it would be easier to just > read the code than ask a bunch of questions. I tried looking for the > handling of reject messages in Android Bitcoin Wallet and BitcoinJ > and didn't really find and handling other than logging exceptions. > Would you mind giving me a couple pointers to where in the code > they're handled? https://github.com/bitcoinj/bitcoinj/blob/master/core/src/main/java/org/bitcoinj/core/TransactionBroadcast.java#L93-L108