From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9C0B9C013A for ; Thu, 14 Jan 2021 05:39:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 814A82047B for ; Thu, 14 Jan 2021 05:39:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zrCeY9HWz0vu for ; Thu, 14 Jan 2021 05:39:19 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.as397444.net (mail.as397444.net [69.59.18.99]) by silver.osuosl.org (Postfix) with ESMTPS id 878AC2046C for ; Thu, 14 Jan 2021 05:39:19 +0000 (UTC) Received: by mail.as397444.net (Postfix) with ESMTPSA id 88594445751; Thu, 14 Jan 2021 05:39:17 +0000 (UTC) X-DKIM-Note: Keys used to sign are likely public at https://as397444.net/dkim/ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mattcorallo.com; s=1610600463; t=1610602757; bh=UAoYIfsv3553/E1Kd0pk232blcVU6b/ssPmj0VpzxVg=; h=From:Subject:Date:References:Cc:In-Reply-To:To:From; b=Zi6pfaAhkKU6ne1zDani8S3DfswngjZM4yOXdA97VSKehuJz2X8IQveOYgVwvyMb5 cwGLaWp9Bt5tFWVyw9/C6ztV4AcrNGb4cdRfxScW1hWkljoqxgQ2DAtmGlmYlXxTB9 P0tDyzNoOa0bcpwG+TFCH7vaqesnLZ0bocFPbBDL9sV2w8HvxG3pSAZA7v04+Pcbl2 lJWDxErRMm5HjcFAIY7lEq0I97mQOALrpUYYRCI5FN30WBY8mT968jzFcTQtHua49Y r5qN3MHn5M0DyieiurKKV1a7sioQ9nxctiGzs+efpGA2ysVZeT22GJeuS3m1Q3Lmgt j7t6MP8njRQsw== Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Matt Corallo Mime-Version: 1.0 (1.0) Date: Thu, 14 Jan 2021 00:39:16 -0500 Message-Id: References: <20210114053257.4ctg3qdvo7s44s72@erisian.com.au> In-Reply-To: <20210114053257.4ctg3qdvo7s44s72@erisian.com.au> To: Anthony Towns Cc: Bitcoin Protocol Discussion Subject: Re: [bitcoin-dev] Proposal for new "disabletx" p2p message X-BeenThere: bitcoin-dev@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Bitcoin Protocol Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2021 05:39:20 -0000 So we=E2=80=99d kill two birds with one stone if all bloom support was dropp= ed. As far as I understand, precomputed filters are now provided via p2p con= nections as well. Matt > On Jan 14, 2021, at 00:33, Anthony Towns wrote: >=20 > =EF=BB=BFOn Wed, Jan 13, 2021 at 01:40:03AM -0500, Matt Corallo via bitcoi= n-dev wrote: >> Out of curiosity, was the interaction between fRelay and bloom disabling e= ver >> specified? ie if you aren=E2=80=99t allowed to enable bloom filters on a c= onnection due >> to resource constraints/new limits, is it ever possible to =E2=80=9Cset=E2= =80=9D fRelay later? >=20 > (Maybe I'm missing something, but...) >=20 > In the current bitcoin implementation, no -- you either set > m_tx_relay->fRelayTxes to true via the VERSION message (either explicitly > or by not setting fRelay), or you enable it later with FILTERLOAD or > FILTERCLEAR, both of which will cause a disconnect if bloom filters > aren't supported. Bloom filter support is (optionally?) indicated via > a service bit (BIP 111), so you could assume you know whether they're > supported as soon as you receive the VERSION line. >=20 > fRelay is specified in BIP 37 as: >=20 > | 1 byte || fRelay || bool || If false then broadcast transactions will > not be announced until a filter{load,add,clear} command is received. If > missing or true, no change in protocol behaviour occurs. >=20 > BIP 60 defines the field as "relay" and references BIP 37. Don't think > it's referenced in any other bips. >=20 > Cheers, > aj >=20